servo: Merge #10619 - mach: Added warning for update-cargo -a (from perlun:add-update-cargo-all-packages-warning); r=Wafflespeanut
authorPer Lundberg <perlun@gmail.com>
Fri, 15 Apr 2016 02:36:18 +0500
changeset 338524 46f8474baaa78ef6e04aaa0894a0551cf8d3f3c6
parent 338523 4009abd4096973da172717f13d3ef274af4a9570
child 338525 b329d6b888c51532e773398b482b7ba028c4686f
push id31307
push usergszorc@mozilla.com
push dateSat, 04 Feb 2017 00:59:06 +0000
treeherdermozilla-central@94079d43835f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersWafflespeanut
servo: Merge #10619 - mach: Added warning for update-cargo -a (from perlun:add-update-cargo-all-packages-warning); r=Wafflespeanut To quote Lars Bergstrom: > yeah, that's a giant footgun :-) Source-Repo: https://github.com/servo/servo Source-Revision: db4481b4509db4be83e0f77a66884feccd1878e0
servo/python/servo/devenv_commands.py
--- a/servo/python/servo/devenv_commands.py
+++ b/servo/python/servo/devenv_commands.py
@@ -57,20 +57,22 @@ class MachCommands(CommandBase):
     @Command('update-cargo',
              description='Update Cargo dependencies',
              category='devenv')
     @CommandArgument(
         'params', default=None, nargs='...',
         help='Command-line arguments to be passed through to cargo update')
     @CommandArgument(
         '--package', '-p', default=None,
-        help='Updates selected package')
+        help='Updates the selected package')
     @CommandArgument(
         '--all-packages', '-a', action='store_true',
-        help='Updates all packages')
+        help='Updates all packages. NOTE! This is very likely to break your ' +
+             'working copy, making it impossible to build servo. Only do ' +
+             'this if you really know what you are doing.')
     def update_cargo(self, params=None, package=None, all_packages=None):
         if not params:
             params = []
 
         if package:
             params += ["-p", package]
         elif all_packages:
             params = []