Bug 1573974: update text-decoration-valid test case r=dholbert,emilio
authorCharlie Marlow <cmarlow@mozilla.com>
Thu, 15 Aug 2019 18:39:23 +0000
changeset 488324 4678b2d85df43ab5869f50df5ce616ef484ebcd6
parent 488323 195166db95ccaae18f182af7ef11e576b29d13e4
child 488325 486c1d9d10912074867ea4b255107007224bedf7
push id36440
push userncsoregi@mozilla.com
push dateFri, 16 Aug 2019 03:57:48 +0000
treeherdermozilla-central@a58b7dc85887 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert, emilio
bugs1573974
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1573974: update text-decoration-valid test case r=dholbert,emilio This patch adds some subtests that exercise the new `text-decoration-thickness` subproperty. It also adjusts the expected serialization for some existing subtests (`currentcolor` and `solid`) which are simply setting a subproperty to its initial value, and therefore should serialize to the shorthand's own effective initial value, which is "none". Differential Revision: https://phabricator.services.mozilla.com/D42058
testing/web-platform/meta/css/css-text-decor/parsing/text-decoration-valid.html.ini
testing/web-platform/tests/css/css-text-decor/parsing/text-decoration-valid.html
--- a/testing/web-platform/meta/css/css-text-decor/parsing/text-decoration-valid.html.ini
+++ b/testing/web-platform/meta/css/css-text-decor/parsing/text-decoration-valid.html.ini
@@ -1,10 +1,11 @@
 [text-decoration-valid.html]
+  prefs: [layout.css.text-decoration-thickness.enabled:true]
+
   [e.style['text-decoration'\] = "rgba(10, 20, 30, 0.4) dotted" should set the property value]
     expected: FAIL
 
-  [e.style['text-decoration'\] = "solid" should set the property value]
+  [e.style['text-decoration'\] = "from-font" should set the property value] # The below tests are failing because of Bug 1574222
     expected: FAIL
 
-  [e.style['text-decoration'\] = "currentcolor" should set the property value]
+  [e.style['text-decoration'\] = "10px" should set the property value]
     expected: FAIL
-
--- a/testing/web-platform/tests/css/css-text-decor/parsing/text-decoration-valid.html
+++ b/testing/web-platform/tests/css/css-text-decor/parsing/text-decoration-valid.html
@@ -4,17 +4,23 @@
 <link rel="help" href="https://drafts.csswg.org/css-text-decor-3/#propdef-text-decoration">
 <meta name="assert" content="text-decoration supports the full grammar '<‘text-decoration-line’> || <‘text-decoration-style’> || <‘text-decoration-color’>'.">
 <script src="/resources/testharness.js"></script>
 <script src="/resources/testharnessreport.js"></script>
 <script src="/css/support/parsing-testcommon.js"></script>
 <script>
 test_valid_value("text-decoration", "none");
 test_valid_value("text-decoration", "line-through");
-test_valid_value("text-decoration", "solid");
-test_valid_value("text-decoration", "currentcolor");
+test_valid_value("text-decoration", "solid", "none");
+test_valid_value("text-decoration", "currentcolor", "none");
+test_valid_value("text-decoration", "auto", "none");
+test_valid_value("text-decoration", "from-font");
+test_valid_value("text-decoration", "10px");
 
 test_valid_value("text-decoration", "double overline underline", "underline overline double");
 test_valid_value("text-decoration", "underline overline line-through red");
 test_valid_value("text-decoration", "rgba(10, 20, 30, 0.4) dotted", "dotted rgba(10, 20, 30, 0.4)");
-
+test_valid_value("text-decoration", "overline green from-font");
 test_valid_value("text-decoration", "underline dashed green");
+test_valid_value("text-decoration", "underline auto", "underline");
+test_valid_value("text-decoration", "line-through 20px");
+test_valid_value("text-decoration", "overline 3em");
 </script>