Bug 1641461 use stereoResponseExplicitTest() for all 2-response convolver explicit channelCountMode tests r=padenot
authorKarl Tomlinson <karlt+@karlt.net>
Wed, 03 Jun 2020 12:52:41 +0000
changeset 533825 4676aa29469d2adc402206de415f4748427e78ee
parent 533824 5b8af5e91633a3e446b9e2894a89310161f9933e
child 533826 c990c7ac488d331554ce5aec5915066d843b5246
push id37478
push userabutkovits@mozilla.com
push dateThu, 04 Jun 2020 09:29:07 +0000
treeherdermozilla-central@e87e4800d332 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1641461
milestone79.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1641461 use stereoResponseExplicitTest() for all 2-response convolver explicit channelCountMode tests r=padenot and adjust description to match the downmixing to mono before convolution. The previous use of stereoResponseTest(), which downmixed to stereo, for 5.1 only was inconsistent with other layouts and provides little additional testing over the clamped-max test, which behaves the same for stereo ConvolverNode input. Differential Revision: https://phabricator.services.mozilla.com/D77969
testing/web-platform/tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan.html
--- a/testing/web-platform/tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan.html
+++ b/testing/web-platform/tests/webaudio/the-audio-api/the-convolvernode-interface/convolver-response-2-chan.html
@@ -121,53 +121,58 @@
                 },
                 should)
                 .then(() => task.done());
           });
 
       audit.define(
           {
             label: '3-channel input explicit mode',
-            description: '3->2 downmix producing 2-channel output'
+            description: '3->1 downmix producing 2-channel output'
           },
           (task, should) => {
             stereoResponseExplicitTest(
                 {
                   numberOfInputs: 3,
                   prefix: '3-in explicit',
                   absoluteThresholds: [0, 0]
                 },
                 should)
                 .then(() => task.done());
           });
 
       audit.define(
           {
             label: '4-channel input explicit mode',
-            description: '4->2 downmix producing 2-channel output'
+            description: '4->1 downmix producing 2-channel output'
           },
           (task, should) => {
             stereoResponseExplicitTest(
                 {
                   numberOfInputs: 4,
                   prefix: '4-in explicit',
                   absoluteThresholds: [3.5763e-7, 2.9803e-7]
                 },
                 should)
                 .then(() => task.done());
           });
 
       audit.define(
           {
             label: '5.1-channel input explicit mode',
-            description: '5.1->2 downmix producing 2-channel output'
+            description: '5.1->1 downmix producing 2-channel output'
           },
           (task, should) => {
-            stereoResponseTest({numberOfInputs: 6, prefix: '5.1-in explicit', absoluteThresholds:
-            [0, 0]}, should)
+            stereoResponseExplicitTest(
+                {
+                  numberOfInputs: 6,
+                  prefix: '5.1-in explicit',
+                  absoluteThresholds: [0, 0]
+                },
+                should)
                 .then(() => task.done());
           });
 
       function stereoResponseTest(options, should) {
         // Create an 4-channel offline context.  The first two channels are for
         // the stereo output of the convolver and the next two channels are for
         // the reference stereo signal.
         let context = new OfflineAudioContext(4, renderFrames, sampleRate);