Backed out changeset a8cc44c79c30 (bug 1241898) for build bustage. r=backout DONTBUILD
authorSebastian Hengst <archaeopteryx@coole-files.de>
Sun, 23 Oct 2016 12:34:15 +0200
changeset 319058 4616f76f25ec7196d6eae80049dd79dbfc001ef6
parent 319057 a8cc44c79c30946426314285c6f63c0f4d2b0295
child 319059 fe38624aa14f6f1769f5d1e049e97ee89e119e34
push id30858
push userryanvm@gmail.com
push dateSun, 23 Oct 2016 17:17:41 +0000
treeherdermozilla-central@a9a41b69f3f9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1241898
milestone52.0a1
backs outa8cc44c79c30946426314285c6f63c0f4d2b0295
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset a8cc44c79c30 (bug 1241898) for build bustage. r=backout DONTBUILD
dom/svg/test/test_SVGUnitTypes.html
dom/webidl/SVGClipPathElement.webidl
dom/webidl/SVGFilterElement.webidl
dom/webidl/SVGGradientElement.webidl
dom/webidl/SVGMaskElement.webidl
dom/webidl/SVGPatternElement.webidl
dom/webidl/SVGUnitTypeValues.webidl
dom/webidl/SVGUnitTypes.webidl
dom/webidl/moz.build
--- a/dom/svg/test/test_SVGUnitTypes.html
+++ b/dom/svg/test/test_SVGUnitTypes.html
@@ -14,28 +14,30 @@ https://bugzilla.mozilla.org/show_bug.cg
 <div id="content" style="display: none"></div>
 
 <pre id="test">
 <script class="testbody" type="application/javascript">
 SimpleTest.waitForExplicitFinish();
 
 function runTest()
 {
-  is(SVGPatternElement.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX, 2,
-     "Pattern should implement SVGUnitTypes values");
-  is(SVGFilteElement.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX, 2,
-     "Filter should implement SVGUnitTypes values");
-  is(SVGMaskElement.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX, 2,
-     "Mask should implement SVGUnitTypes values");
-  is(SVGClipPathElement.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX, 2,
-     "ClipPath should implement SVGUnitTypes values");
-  is(SVGLinearGradientElement.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX, 2,
-     "LinearGradient should implement SVGUnitTypes values");
-  is(SVGRadialGradientElement.SVG_UNIT_TYPE_OBJECTBOUNDINGBOX, 2,
-     "RadialGradient should implement SVGUnitTypes values");
+  ok(document.createElementNS("http://www.w3.org/2000/svg", "pattern")
+       instanceof SVGUnitTypes, "Pattern should implement SVGUnitTypes");
+  ok(document.createElementNS("http://www.w3.org/2000/svg", "filter")
+       instanceof SVGUnitTypes, "Filter should implement SVGUnitTypes");
+  ok(document.createElementNS("http://www.w3.org/2000/svg", "mask")
+       instanceof SVGUnitTypes, "Mask should implement SVGUnitTypes");
+  ok(document.createElementNS("http://www.w3.org/2000/svg", "clipPath")
+       instanceof SVGUnitTypes, "ClipPath should implement SVGUnitTypes");
+  ok(document.createElementNS("http://www.w3.org/2000/svg", "linearGradient")
+       instanceof SVGUnitTypes, "LinearGradient should implement SVGUnitTypes");
+  ok(document.createElementNS("http://www.w3.org/2000/svg", "radialGradient")
+       instanceof SVGUnitTypes, "radialGradient should implement SVGUnitTypes");
+  ok(!(document.createElementNS("http://www.w3.org/2000/svg", "svg")
+       instanceof SVGUnitTypes), "svg should not implement SVGUnitTypes");
   SimpleTest.finish();
 }
 
 window.addEventListener("load", runTest, false);
 </script>
 </pre>
 </body>
 </html>
--- a/dom/webidl/SVGClipPathElement.webidl
+++ b/dom/webidl/SVGClipPathElement.webidl
@@ -12,10 +12,10 @@
 
 interface SVGClipPathElement : SVGElement {
   [Constant]
   readonly attribute SVGAnimatedEnumeration clipPathUnits;
   [Constant]
   readonly attribute SVGAnimatedTransformList transform;
 };
 
-SVGClipPathElement implements SVGUnitTypeValues;
+SVGClipPathElement implements SVGUnitTypes;
 
--- a/dom/webidl/SVGFilterElement.webidl
+++ b/dom/webidl/SVGFilterElement.webidl
@@ -23,10 +23,10 @@ interface SVGFilterElement : SVGElement 
   readonly attribute SVGAnimatedLength width;
   [Constant]
   readonly attribute SVGAnimatedLength height;
 
   // ImageData apply(ImageData source);
 };
 
 SVGFilterElement implements SVGURIReference;
-SVGFilterElement implements SVGUnitTypeValues;
+SVGFilterElement implements SVGUnitTypes;
 
--- a/dom/webidl/SVGGradientElement.webidl
+++ b/dom/webidl/SVGGradientElement.webidl
@@ -22,9 +22,9 @@ interface SVGGradientElement : SVGElemen
   readonly attribute SVGAnimatedEnumeration gradientUnits;
   [Constant]
   readonly attribute SVGAnimatedTransformList gradientTransform;
   [Constant]
   readonly attribute SVGAnimatedEnumeration spreadMethod;
 };
 
 SVGGradientElement implements SVGURIReference;
-SVGGradientElement implements SVGUnitTypeValues;
+SVGGradientElement implements SVGUnitTypes;
--- a/dom/webidl/SVGMaskElement.webidl
+++ b/dom/webidl/SVGMaskElement.webidl
@@ -25,10 +25,10 @@ interface SVGMaskElement : SVGElement {
   [Constant]
   readonly attribute SVGAnimatedLength y;
   [Constant]
   readonly attribute SVGAnimatedLength width;
   [Constant]
   readonly attribute SVGAnimatedLength height;
 };
 
-SVGMaskElement implements SVGUnitTypeValues;
+SVGMaskElement implements SVGUnitTypes;
 
--- a/dom/webidl/SVGPatternElement.webidl
+++ b/dom/webidl/SVGPatternElement.webidl
@@ -24,9 +24,9 @@ interface SVGPatternElement : SVGElement
   [Constant]
   readonly attribute SVGAnimatedLength width;
   [Constant]
   readonly attribute SVGAnimatedLength height;
 };
 
 SVGPatternElement implements SVGFitToViewBox;
 SVGPatternElement implements SVGURIReference;
-SVGPatternElement implements SVGUnitTypeValues;
+SVGPatternElement implements SVGUnitTypes;
deleted file mode 100644
--- a/dom/webidl/SVGUnitTypeValues.webidl
+++ /dev/null
@@ -1,19 +0,0 @@
-/* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
-/* This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this file,
- * You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * The origin of this IDL file is
- * https://svgwg.org/svg2-draft/
- *
- * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
- * liability, trademark and document use rules apply.
- */
-
-[NoInterfaceObject]
-interface SVGUnitTypeValues {
-  // Unit Types
-  const unsigned short SVG_UNIT_TYPE_UNKNOWN = 0;
-  const unsigned short SVG_UNIT_TYPE_USERSPACEONUSE = 1;
-  const unsigned short SVG_UNIT_TYPE_OBJECTBOUNDINGBOX = 2;
-};
--- a/dom/webidl/SVGUnitTypes.webidl
+++ b/dom/webidl/SVGUnitTypes.webidl
@@ -6,11 +6,13 @@
  * The origin of this IDL file is
  * https://svgwg.org/svg2-draft/
  *
  * Copyright © 2012 W3C® (MIT, ERCIM, Keio), All Rights Reserved. W3C
  * liability, trademark and document use rules apply.
  */
 
 interface SVGUnitTypes {
+  // Unit Types
+  const unsigned short SVG_UNIT_TYPE_UNKNOWN = 0;
+  const unsigned short SVG_UNIT_TYPE_USERSPACEONUSE = 1;
+  const unsigned short SVG_UNIT_TYPE_OBJECTBOUNDINGBOX = 2;
 };
-
-SVGUnitTypes implements SVGUnitTypesValues;
--- a/dom/webidl/moz.build
+++ b/dom/webidl/moz.build
@@ -529,17 +529,16 @@ WEBIDL_FILES = [
     'SVGTextElement.webidl',
     'SVGTextPathElement.webidl',
     'SVGTextPositioningElement.webidl',
     'SVGTitleElement.webidl',
     'SVGTransform.webidl',
     'SVGTransformList.webidl',
     'SVGTSpanElement.webidl',
     'SVGUnitTypes.webidl',
-    'SVGUnitTypeValues.webidl',
     'SVGURIReference.webidl',
     'SVGUseElement.webidl',
     'SVGViewElement.webidl',
     'SVGZoomAndPan.webidl',
     'SVGZoomAndPanValues.webidl',
     'SVGZoomEvent.webidl',
     'SystemUpdate.webidl',
     'TCPServerSocket.webidl',