Bug 1073425 - Initialize mNewFrameCallback in constructor. r=sotaro
authorJohn Lin <jolin@mozilla.com>
Sun, 28 Sep 2014 19:33:00 +0200
changeset 207642 4578cddde9f7d96204d3d573e0a0bb69755f7b1b
parent 207641 47e245533187c543c7c47beff52ad9e5afab01ac
child 207643 199bffb1f6fb11fe7e3857448c693203fbdf4781
push id27564
push userryanvm@gmail.com
push dateMon, 29 Sep 2014 18:57:04 +0000
treeherdermozilla-central@ce9a0b34225e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssotaro
bugs1073425
milestone35.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1073425 - Initialize mNewFrameCallback in constructor. r=sotaro
widget/gonk/nativewindow/GonkNativeWindowJB.cpp
widget/gonk/nativewindow/GonkNativeWindowKK.cpp
--- a/widget/gonk/nativewindow/GonkNativeWindowJB.cpp
+++ b/widget/gonk/nativewindow/GonkNativeWindowJB.cpp
@@ -32,17 +32,18 @@
 #define BI_LOGE(...) __android_log_print(ANDROID_LOG_ERROR, LOG_TAG, __VA_ARGS__)
 
 using namespace mozilla;
 using namespace mozilla::layers;
 
 namespace android {
 
 GonkNativeWindow::GonkNativeWindow(int bufferCount) :
-    GonkConsumerBase(new GonkBufferQueue(true) )
+    GonkConsumerBase(new GonkBufferQueue(true) ),
+    mNewFrameCallback(nullptr)
 {
     mBufferQueue->setMaxAcquiredBufferCount(bufferCount);
 }
 
 GonkNativeWindow::~GonkNativeWindow() {
 }
 
 void GonkNativeWindow::setName(const String8& name) {
--- a/widget/gonk/nativewindow/GonkNativeWindowKK.cpp
+++ b/widget/gonk/nativewindow/GonkNativeWindowKK.cpp
@@ -24,17 +24,18 @@
 #include "GrallocImages.h"
 
 using namespace mozilla;
 using namespace mozilla::layers;
 
 namespace android {
 
 GonkNativeWindow::GonkNativeWindow(int bufferCount) :
-    GonkConsumerBase(new GonkBufferQueue(true), false)
+    GonkConsumerBase(new GonkBufferQueue(true), false),
+    mNewFrameCallback(nullptr)
 {
     mConsumer->setMaxAcquiredBufferCount(bufferCount);
 }
 
 GonkNativeWindow::GonkNativeWindow(const sp<GonkBufferQueue>& bq,
         uint32_t consumerUsage, int bufferCount, bool controlledByApp) :
     GonkConsumerBase(bq, controlledByApp)
 {