Bug 1672353 - Disable clang warnings when compiling ICU. r=jwalden,andi
authorTom Schuster <evilpies@gmail.com>
Sat, 24 Oct 2020 21:23:15 +0000
changeset 554344 454ea3b162565554234c7a28c7106110b6523da0
parent 554343 b43d1c8c7639169ef393aec68578a403c7865a08
child 554345 59f99782b6f765539848510f3e4fc01b11076bc4
push id37892
push usernbeleuzu@mozilla.com
push dateSun, 25 Oct 2020 21:41:16 +0000
treeherdermozilla-central@61c35792ca70 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjwalden, andi
bugs1672353
milestone84.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1672353 - Disable clang warnings when compiling ICU. r=jwalden,andi Differential Revision: https://phabricator.services.mozilla.com/D94291
config/external/icu/defs.mozbuild
--- a/config/external/icu/defs.mozbuild
+++ b/config/external/icu/defs.mozbuild
@@ -42,21 +42,33 @@ elif CONFIG['OS_TARGET'] == 'WINNT':
         f for f in COMPILE_FLAGS['OS_CXXFLAGS'] if f != '-GR-'
     ] + ['-GR']
 
 DisableStlWrapping()
 AllowCompilerWarnings()
 
 # We allow compiler warnings, but we can at least cut down on spammy
 # warnings that get triggered for every file.
-if CONFIG['CC_TYPE'] == 'clang-cl':
+if CONFIG['CC_TYPE'] in ('clang', 'clang-cl'):
     CFLAGS += [
+        '-Wno-c++20-compat',
+        '-Wno-comma',
+        '-Wno-implicit-const-int-float-conversion',
         '-Wno-macro-redefined',
         '-Wno-microsoft-include',
+        '-Wno-tautological-unsigned-enum-zero-compare',
+        '-Wno-unreachable-code-loop-increment',
+        '-Wno-unreachable-code-return',
     ]
     CXXFLAGS += [
+        '-Wno-c++20-compat',
+        '-Wno-comma',
+        '-Wno-implicit-const-int-float-conversion',
         '-Wno-macro-redefined',
         '-Wno-microsoft-include',
+        '-Wno-tautological-unsigned-enum-zero-compare',
+        '-Wno-unreachable-code-loop-increment',
+        '-Wno-unreachable-code-return',
     ]
 
 for k, v in DEFINES.items():
     if k != 'UCONFIG_NO_LEGACY_CONVERSION':
         HOST_DEFINES[k] = v