Bug 1416724 - part 4 - AbstractThread::Dispatch return value check in netwerk/base, r=smaug
☠☠ backed out by 7613f8e20ad5 ☠ ☠
authorAndrea Marchesini <amarchesini@mozilla.com>
Wed, 15 Nov 2017 07:58:03 +0100
changeset 391953 45352aa4319debd6ad3445f2729db197ffc83eac
parent 391952 01d1e5263bcd56fadf19b446b48c4ab2c9de6891
child 391954 3d7896bf89f74163c53332640806fe2bbc46acbc
push id32909
push usercbrindusan@mozilla.com
push dateWed, 15 Nov 2017 22:25:14 +0000
treeherdermozilla-central@f41930a869a8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssmaug
bugs1416724
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1416724 - part 4 - AbstractThread::Dispatch return value check in netwerk/base, r=smaug
netwerk/base/nsNetUtil.cpp
--- a/netwerk/base/nsNetUtil.cpp
+++ b/netwerk/base/nsNetUtil.cpp
@@ -1543,18 +1543,17 @@ private:
             return NS_ERROR_FAILURE;
         }
 
         mTaskQueue = new TaskQueue(target.forget());
 
         MonitorAutoLock lock(mMonitor);
 
         nsCOMPtr<nsIRunnable> runnable = this;
-        nsresult rv = mTaskQueue->Dispatch(runnable.forget(),
-                                           AbstractThread::DontAssertDispatchSuccess);
+        nsresult rv = mTaskQueue->Dispatch(runnable.forget());
         NS_ENSURE_SUCCESS(rv, rv);
 
         lock.Wait();
 
         return mAsyncResult;
     }
 
     // This method runs on the I/O Thread when the owning thread is blocked by
@@ -1595,18 +1594,17 @@ private:
         if (NS_SUCCEEDED(rv)) {
             mWrittenData += writtenData;
             if (mCount != -1) {
                 MOZ_ASSERT(mCount >= writtenData);
                 mCount -= writtenData;
             }
 
             nsCOMPtr<nsIRunnable> runnable = this;
-            rv = mTaskQueue->Dispatch(runnable.forget(),
-                                      AbstractThread::DontAssertDispatchSuccess);
+            rv = mTaskQueue->Dispatch(runnable.forget());
             if (NS_WARN_IF(NS_FAILED(rv))) {
                 OperationCompleted(rv);
             }
         
             return NS_OK;
         }
 
         // Async wait...