Bug 1360429 - Part 1. inline arm assember for YCBCR should be on arm only. r=sotaro
authorMakoto Kato <m_kato@ga2.so-net.ne.jp>
Fri, 28 Apr 2017 13:22:07 +0900
changeset 358162 44e7fc73aeb508c0a363319ec48a5db4b175bb9b
parent 358161 3aab38317ccd9db6184682188504ae0f65ac20df
child 358163 edea8382d3f45ed2fdd38c42f210a63c139f3be2
push id31818
push userarchaeopteryx@coole-files.de
push dateSun, 14 May 2017 16:01:21 +0000
treeherdermozilla-central@3a801856dea9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssotaro
bugs1360429
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1360429 - Part 1. inline arm assember for YCBCR should be on arm only. r=sotaro ycvcr_to_rgb565 uses inline assember for arm neon. Since it is different for aarch64's assembler, we should define HAVE_YCBCR_TO_RGB565 on arm32 only. MozReview-Commit-ID: 4c2n1luvVvC
gfx/ycbcr/ycbcr_to_rgb565.h
--- a/gfx/ycbcr/ycbcr_to_rgb565.h
+++ b/gfx/ycbcr/ycbcr_to_rgb565.h
@@ -2,17 +2,17 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef MEDIA_BASE_YCBCR_TO_RGB565_H_
 #define MEDIA_BASE_YCBCR_TO_RGB565_H_
 #include "yuv_convert.h"
 #include "mozilla/arm.h"
 
 // It's currently only worth including this if we have NEON support.
-#ifdef MOZILLA_MAY_SUPPORT_NEON
+#if defined(__arm__) && defined(MOZILLA_MAY_SUPPORT_NEON)
 #define HAVE_YCBCR_TO_RGB565 1
 #endif
 
 namespace mozilla {
 
 namespace gfx {
 
 #ifdef HAVE_YCBCR_TO_RGB565