Bug 1294605 - Media element captureStream() streams shouldn't keep devices alive. r=jib
☠☠ backed out by a8ae71a79bb8 ☠ ☠
authorAndreas Pehrson <pehrsons@gmail.com>
Mon, 29 Aug 2016 16:27:11 +0200
changeset 318733 443a94083e005ad58574d3571be3299ffc6d8029
parent 318732 0593feead369348ae725d5756bdfcb7d44429221
child 318734 c0c023815311c2632a9763b696492342b0e829e1
push id30850
push usercbook@mozilla.com
push dateThu, 20 Oct 2016 14:47:50 +0000
treeherdermozilla-central@3f0aeafe59c4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjib
bugs1294605
milestone52.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1294605 - Media element captureStream() streams shouldn't keep devices alive. r=jib MozReview-Commit-ID: 3tSFbygTZs1
dom/html/HTMLMediaElement.cpp
--- a/dom/html/HTMLMediaElement.cpp
+++ b/dom/html/HTMLMediaElement.cpp
@@ -2205,25 +2205,21 @@ public:
                                            MediaStreamTrackSource)
 
   explicit StreamCaptureTrackSource(MediaStreamTrackSource* aCapturedTrackSource)
     : MediaStreamTrackSource(aCapturedTrackSource->GetPrincipal(),
                              true,
                              nsString())
     , mCapturedTrackSource(aCapturedTrackSource)
   {
-    mCapturedTrackSource->RegisterSink(this);
   }
 
   void Destroy() override
   {
     MOZ_ASSERT(mCapturedTrackSource);
-    if (mCapturedTrackSource) {
-      mCapturedTrackSource->UnregisterSink(this);
-    }
   }
 
   MediaSourceEnum GetMediaSource() const override
   {
     return MediaSourceEnum::Other;
   }
 
   CORSMode GetCORSMode() const override