Bug 1529468 - Remove devtools.inspector.fonthighlighter.enabled pref. r=gl
authorRainier G <rainier.f.go@gmail.com>
Fri, 22 Feb 2019 00:22:01 -0500
changeset 460555 43dea2157ab5388cc8619c3e876970b64295c84b
parent 460554 9c4636d8d2ffb58001ccfc76c4ec5a529f068173
child 460556 02aebe5267552208953599fbdf2879030227a2c6
push id35594
push userccoroiu@mozilla.com
push dateFri, 22 Feb 2019 16:31:14 +0000
treeherdermozilla-central@826b59e57fe4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1529468
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1529468 - Remove devtools.inspector.fonthighlighter.enabled pref. r=gl
devtools/client/inspector/fonts/components/FontName.js
devtools/client/preferences/devtools-client.js
--- a/devtools/client/inspector/fonts/components/FontName.js
+++ b/devtools/client/inspector/fonts/components/FontName.js
@@ -1,23 +1,20 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 "use strict";
 
-const Services = require("Services");
 const { PureComponent } = require("devtools/client/shared/vendor/react");
 const dom = require("devtools/client/shared/vendor/react-dom-factories");
 const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
 
 const Types = require("../types");
 
-const FONT_HIGHLIGHTER_PREF = "devtools.inspector.fonthighlighter.enabled";
-
 class FontName extends PureComponent {
   static get propTypes() {
     return {
       font: PropTypes.shape(Types.font).isRequired,
       onToggleFontHighlight: PropTypes.func.isRequired,
     };
   }
 
@@ -41,22 +38,20 @@ class FontName extends PureComponent {
       font,
       onToggleFontHighlight,
     } = this.props;
 
     onToggleFontHighlight(font, false);
   }
 
   render() {
-    const options = {
-      className: "font-name",
-    };
-
-    if (Services.prefs.getBoolPref(FONT_HIGHLIGHTER_PREF)) {
-      options.onMouseOver = this.onNameMouseOver;
-      options.onMouseOut = this.onNameMouseOut;
-    }
-
-    return dom.span(options, this.props.font.name);
+    return dom.span(
+      {
+        className: "font-name",
+        onMouseOver: this.onNameMouseOver,
+        onMouseOut: this.onNameMouseOut,
+      },
+      this.props.font.name
+    );
   }
 }
 
 module.exports = FontName;
--- a/devtools/client/preferences/devtools-client.js
+++ b/devtools/client/preferences/devtools-client.js
@@ -45,18 +45,16 @@ pref("devtools.inspector.show_pseudo_ele
 // The default size for image preview tooltips in the rule-view/computed-view/markup-view
 pref("devtools.inspector.imagePreviewTooltipSize", 300);
 // Enable user agent style inspection in rule-view
 pref("devtools.inspector.showUserAgentStyles", false);
 // Show all native anonymous content
 pref("devtools.inspector.showAllAnonymousContent", false);
 // Show user agent shadow roots
 pref("devtools.inspector.showUserAgentShadowRoots", false);
-// Enable the font highlight-on-hover feature
-pref("devtools.inspector.fonthighlighter.enabled", true);
 // Enable the new Rules View
 pref("devtools.inspector.new-rulesview.enabled", false);
 
 // Flexbox preferences
 // Whether or not to show the combined flexbox and box model highlighter.
 #if defined(NIGHTLY_BUILD) || defined(MOZ_DEV_EDITION)
 pref("devtools.inspector.flexboxHighlighter.combine", true);
 #else