Bug 1498914 - Removal of Pocket icon from address bar persist across a restart r=adw
authorScottDowne <scott.downe@gmail.com>
Tue, 16 Oct 2018 18:57:27 +0000
changeset 441725 43db36acc04fc464e9f75b79bf635e7cc2ba328b
parent 441724 b6780702981d863bfd913ca404d5b5209b952066
child 441726 bfd23ad81ef4074f395036cc62fa31ff3cd97f96
child 441729 afdc3066f12cf33cfcf05cd4524b6d72b215acb2
push id34873
push userdluca@mozilla.com
push dateWed, 17 Oct 2018 22:54:14 +0000
treeherdermozilla-central@bfd23ad81ef4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersadw
bugs1498914
milestone64.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1498914 - Removal of Pocket icon from address bar persist across a restart r=adw Differential Revision: https://phabricator.services.mozilla.com/D8889
browser/components/pocket/content/SaveToPocket.jsm
--- a/browser/components/pocket/content/SaveToPocket.jsm
+++ b/browser/components/pocket/content/SaveToPocket.jsm
@@ -523,14 +523,11 @@ var SaveToPocket = {
     // watch pref change and enable/disable if necessary
     Services.prefs.addObserver("extensions.pocket.enabled", prefObserver);
     if (!Services.prefs.getBoolPref("extensions.pocket.enabled"))
       return;
     PocketOverlay.startup();
   },
 
   uninit() {
-    // For speed sake, we should only do a shutdown if we're being disabled.
-    // On an app shutdown, just let it fade away...
     Services.prefs.removeObserver("extensions.pocket.enabled", prefObserver);
-    PocketOverlay.shutdown();
   },
 };