Bug 1622138 [wpt PR 22230] - Make computedStyleMap return the computed value for lineHeight, a=testonly
authorGeorge Steel <gtsteel@google.com>
Sat, 14 Mar 2020 11:29:36 +0000
changeset 518853 42881b0536f855b7d1c08017dbbc37f120502315
parent 518852 e633baee860b092ffb258770fba74e89bd68e9ae
child 518854 65eedd9b56ee16dc1b0f23ad5835cb7805dd2d94
push id37217
push userccoroiu@mozilla.com
push dateSun, 15 Mar 2020 21:37:59 +0000
treeherdermozilla-central@f9fc9427476e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1622138, 22230, 2101858, 750170
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1622138 [wpt PR 22230] - Make computedStyleMap return the computed value for lineHeight, a=testonly Automatic update from web-platform-tests Make computedStyleMap return the computed value for lineHeight It previously returned the resolved value as produced by ValueForLineHeight (this property is unique in that the computed and resolved values differ even without a layout object). Introduce another serializer ComputedValueForLineHeight which produces the actual computed value. Change-Id: Ic27d9a4fe7c67cbbb577ec4e4efed14a88a846c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101858 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#750170} -- wpt-commits: 550ffc84d3c79e80ea4b8b90a2489a0b8426aa1b wpt-pr: 22230
testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/line-height.html
--- a/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/line-height.html
+++ b/testing/web-platform/tests/css/css-typed-om/the-stylepropertymap/properties/line-height.html
@@ -18,17 +18,17 @@ runPropertyTests('line-height', [
   {
     syntax: '<length>',
     specified: assert_is_equal_with_range_handling,
     computed: (_, result) => assert_is_unit('px', result)
   },
   {
     syntax: '<number>',
     specified: assert_is_equal_with_range_handling,
-    computed: (_, result) => assert_is_unit('px', result)
+    computed: (_, result) => assert_is_unit('number', result)
   },
   {
     syntax: '<percentage>',
     specified: assert_is_equal_with_range_handling,
     computed: (_, result) => assert_is_unit('px', result)
   },
 ]);