Bug 1726562 - Remove option to disable software webrender for popups. r=jrmuizel
authorMatt Woodrow <mwoodrow@mozilla.com>
Tue, 24 Aug 2021 04:06:34 +0000
changeset 589644 425313809206add668132f5653c0bba3a91e79d5
parent 589643 60b0cb3f37fe04d9049fa1a262122bcd40d75d42
child 589645 e8046a319fbf5dddbcf838fa3dbfc3288b55c0c8
push id38731
push usercbrindusan@mozilla.com
push dateTue, 24 Aug 2021 09:47:24 +0000
treeherdermozilla-central@7857f4c37a92 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel
bugs1726562
milestone93.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1726562 - Remove option to disable software webrender for popups. r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D123159
gfx/thebes/gfxPlatform.cpp
gfx/thebes/gfxPlatform.h
modules/libpref/init/StaticPrefList.yaml
widget/nsBaseWidget.cpp
--- a/gfx/thebes/gfxPlatform.cpp
+++ b/gfx/thebes/gfxPlatform.cpp
@@ -1186,25 +1186,16 @@ bool gfxPlatform::IsHeadless() {
   }
   return headless;
 }
 
 /* static */
 bool gfxPlatform::UseWebRender() { return gfx::gfxVars::UseWebRender(); }
 
 /* static */
-bool gfxPlatform::DoesFissionForceWebRender() {
-  // Because WebRender doesn't currently support all of the tests that Fission
-  // runs in CI, we only require WebRender for users who are enrolled in the
-  // the Fission experiment. This applies to both the control and the treatment
-  // groups, so they are as comparable as possible.
-  return FissionExperimentEnrolled();
-}
-
-/* static */
 bool gfxPlatform::UseRemoteCanvas() {
   return XRE_IsContentProcess() && gfx::gfxVars::RemoteCanvasEnabled();
 }
 
 /* static */
 bool gfxPlatform::IsBackendAccelerated(
     const mozilla::gfx::BackendType aBackendType) {
   return aBackendType == BackendType::DIRECT2D ||
--- a/gfx/thebes/gfxPlatform.h
+++ b/gfx/thebes/gfxPlatform.h
@@ -226,18 +226,16 @@ class gfxPlatform : public mozilla::laye
   static int32_t MaxTextureSize();
   static int32_t MaxAllocSize();
   static void InitMoz2DLogging();
 
   static bool IsHeadless();
 
   static bool UseWebRender();
 
-  static bool DoesFissionForceWebRender();
-
   static bool UseRemoteCanvas();
 
   static bool IsBackendAccelerated(
       const mozilla::gfx::BackendType aBackendType);
 
   static bool CanMigrateMacGPUs();
 
   /**
--- a/modules/libpref/init/StaticPrefList.yaml
+++ b/modules/libpref/init/StaticPrefList.yaml
@@ -5343,23 +5343,16 @@
 #endif
   mirror: once
 
 - name: gfx.webrender.software.d3d11.upload-mode
   type: RelaxedAtomicInt32
   value: 4
   mirror: always
 
-# Whether to allow widgets that don't support acceleration to use WebRender
-# software backend
-- name: gfx.webrender.software.unaccelerated-widget.allow
-  type: RelaxedAtomicBool
-  value: true
-  mirror: always
-
 # Whether to force widgets to don't support acceleration to use WebRender
 # despite that
 - name: gfx.webrender.unaccelerated-widget.force
   type: RelaxedAtomicBool
   value: false
   mirror: always
 
 # Enable a lower quality, but higher performance pinch-zoom mode. Primarily
--- a/widget/nsBaseWidget.cpp
+++ b/widget/nsBaseWidget.cpp
@@ -1331,22 +1331,18 @@ already_AddRefed<LayerManager> nsBaseWid
     // BasicCompositor.
     bool supportsAcceleration = WidgetTypeSupportsAcceleration();
     bool enableWR;
     bool enableSWWR;
     if (supportsAcceleration ||
         StaticPrefs::gfx_webrender_unaccelerated_widget_force()) {
       enableWR = gfx::gfxVars::UseWebRender();
       enableSWWR = gfx::gfxVars::UseSoftwareWebRender();
-    } else if (gfxPlatform::DoesFissionForceWebRender() ||
-               StaticPrefs::
-                   gfx_webrender_software_unaccelerated_widget_allow()) {
+    } else {
       enableWR = enableSWWR = gfx::gfxVars::UseWebRender();
-    } else {
-      enableWR = enableSWWR = false;
     }
     MOZ_RELEASE_ASSERT(enableWR);
     bool enableAPZ = UseAPZ();
     CompositorOptions options(enableAPZ, enableSWWR);
 
 #ifdef XP_WIN
     if (supportsAcceleration) {
       options.SetAllowSoftwareWebRenderD3D11(