Backed out changeset 38aa7d0b471f (bug 1708866) for causing mochitest failures in browser_downloads_panel_height. CLOSED TREE
authorSandor Molnar <smolnar@mozilla.com>
Mon, 23 Aug 2021 19:23:58 +0300
changeset 589589 41af88f6fae5aa8df07dfd93e1058e661c0b6784
parent 589588 3e0bb4b1cdcbcff7d28644618fe28aacd5c208c2
child 589590 506436e98965d55a2232e45e8af4c5bc718d001d
push id38728
push userncsoregi@mozilla.com
push dateMon, 23 Aug 2021 21:41:28 +0000
treeherdermozilla-central@41af88f6fae5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1708866
milestone93.0a1
backs out38aa7d0b471fcd59f644e214cc9da5caed16d6c5
first release with
nightly linux32
41af88f6fae5 / 93.0a1 / 20210823214128 / files
nightly linux64
41af88f6fae5 / 93.0a1 / 20210823214128 / files
nightly mac
41af88f6fae5 / 93.0a1 / 20210823214128 / files
nightly win32
41af88f6fae5 / 93.0a1 / 20210823214128 / files
nightly win64
41af88f6fae5 / 93.0a1 / 20210823214128 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 38aa7d0b471f (bug 1708866) for causing mochitest failures in browser_downloads_panel_height. CLOSED TREE
browser/themes/shared/customizableui/panelUI.inc.css
browser/themes/shared/downloads/downloads.inc.css
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -1339,17 +1339,17 @@ menuitem.subviewbutton@menuStateActive@,
 #widget-overflow-mainView > toolbarseparator,
 #widget-overflow-mainView > .panel-subview-body > toolbarseparator,
 .PanelUI-subView toolbarseparator,
 #permission-popup-mainView > toolbarseparator,
 #protections-popup-multiView toolbarseparator,
 #identity-popup-mainView toolbarseparator,
 #identity-popup-securityView > toolbarseparator,
 #editBookmarkPanel toolbarseparator,
-#downloadsFooterButtons > toolbarseparator,
+#downloadsPanel-mainView toolbarseparator,
 .cui-widget-panelview menuseparator,
 .cui-widget-panel toolbarseparator {
   appearance: none;
   min-height: 0;
   border-top: 1px solid var(--panel-separator-color);
   border-bottom: none;
   margin: var(--panel-separator-margin);
   padding: 0;
--- a/browser/themes/shared/downloads/downloads.inc.css
+++ b/browser/themes/shared/downloads/downloads.inc.css
@@ -12,29 +12,29 @@
 %define itemFocused #downloadsListBox:focus > @item@[selected]
 
 /*** Panel and outer controls ***/
 
 #downloadsListBox {
   background: transparent;
   color: inherit;
   appearance: none;
-  margin: 0;
+  margin: 0.31em 0 0.93em;
 }
 
 #emptyDownloads {
   padding: 1.5em 0.62em 2.1em;
   margin: 0;
   pointer-events: none;
 }
 
 @item@ {
   height: 3.1em;
-  padding: 8px 0.31em;
-  margin: 0 0 8px;
+  padding: 0.31em;
+  margin: 0.31em 0;
   border-radius: 4px;
 }
 
 @itemFinished@[exists]:hover:not(.downloadHoveringButton),
 button.downloadButton:hover,
 @item@[verdict]:hover,
 @item@:hover:is(.openWhenFinished),
 .downloadsPanelFooterButton:hover {
@@ -158,17 +158,17 @@ button.downloadButton {
 }
 
 @item@ {
   background: transparent;
   color: inherit;
 }
 
 @item@:last-child {
-  margin-bottom: 0;
+  border-bottom: none;
 }
 
 .downloadTypeIcon {
   width: 32px;
   height: 32px;
 }
 
 .downloadBlockedBadge {
@@ -281,15 +281,10 @@ button.downloadButton {
 
 #downloadsPanel-blockedSubview-details1,
 #downloadsPanel-blockedSubview-details2 {
   font-size: calc(100% * var(--downloads-item-font-size-factor));
   margin-bottom: 16px;
   opacity: var(--downloads-item-details-opacity);
 }
 
-/*** Toolbarseparator ***/
-#downloadsFooterButtons > toolbarseparator {
-  margin-inline: 0;
-}
-
 /*** Progressmeter ***/
 %include progressmeter.inc.css