Bug 1540314: Devtools promise actor: Use ActorPool 'destroy' method. r=gl
authorJim Blandy <jimb@mozilla.com>
Fri, 03 May 2019 01:19:20 +0000
changeset 472914 40dad5764be780d7f1cae6e79075923386bd82f5
parent 472913 1bd55e7d7d153ca0b84a0da4317fdd250f2439aa
child 472915 264bdfcb9ebb54017a4abc88b870def85e486de8
push id35983
push userncsoregi@mozilla.com
push dateWed, 08 May 2019 03:38:51 +0000
treeherdermozilla-central@0e9e744accd3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgl
bugs1540314
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1540314: Devtools promise actor: Use ActorPool 'destroy' method. r=gl The prior code calls '.cleanup()', but ActorPools have no 'cleanup' method. I think it means to call 'destroy'. Differential Revision: https://phabricator.services.mozilla.com/D29755
devtools/server/actors/promises.js
--- a/devtools/server/actors/promises.js
+++ b/devtools/server/actors/promises.js
@@ -186,15 +186,15 @@ var PromisesActor = protocol.ActorClassW
     };
   },
 
   _onWindowReady: expectState("attached", function({ isTopLevel }) {
     if (!isTopLevel) {
       return;
     }
 
-    this._navigationLifetimePool.cleanup();
+    this._navigationLifetimePool.destroy();
     this.dbg.removeAllDebuggees();
     this.dbg.addDebuggees();
   }),
 });
 
 exports.PromisesActor = PromisesActor;