Bug 1253590, part 4 - Follow-up to return the correct type. r=bustage
authorJonathan Watt <jwatt@jwatt.org>
Sat, 12 Mar 2016 18:43:40 +0000
changeset 290200 406c780a3817d283d9a65ab2a037f1131e96f7c9
parent 290199 ad88856cdfdc498bf299d5ac074699a4061b5ada
child 290201 68c978a14bbcec031f298d0a62b7fe2288e07a40
push id30114
push usercbook@mozilla.com
push dateThu, 24 Mar 2016 15:15:54 +0000
treeherdermozilla-central@24c5fbde4488 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage
bugs1253590
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1253590, part 4 - Follow-up to return the correct type. r=bustage
layout/svg/nsSVGClipPathFrame.cpp
--- a/layout/svg/nsSVGClipPathFrame.cpp
+++ b/layout/svg/nsSVGClipPathFrame.cpp
@@ -95,17 +95,17 @@ nsSVGClipPathFrame::GetClipMask(gfxConte
 
   // A clipPath can reference another clipPath.  We re-enter this method for
   // each clipPath in a reference chain, so here we limit chain length:
   static int16_t sRefChainLengthCounter = AutoReferenceLimiter::notReferencing;
   AutoReferenceLimiter
     refChainLengthLimiter(&sRefChainLengthCounter,
                           MAX_SVG_CLIP_PATH_REFERENCE_CHAIN_LENGTH);
   if (!refChainLengthLimiter.Reference()) {
-    return false; // Reference chain is too long!
+    return nullptr; // Reference chain is too long!
   }
 
   // And to prevent reference loops we check that this clipPath only appears
   // once in the reference chain (if any) that we're currently processing:
   AutoReferenceLimiter refLoopDetector(&mReferencing, 1);
   if (!refLoopDetector.Reference()) {
     return nullptr; // Reference loop!
   }