Bug 1654684 - Move chevron.svg to toolkit. r=remote-protocol-reviewers,desktop-theme-reviewers,ntim
authorSam Foster <sfoster@mozilla.com>
Wed, 09 Dec 2020 20:49:25 +0000
changeset 560088 3f892edf01395873d756bf4599eb1275dcb20143
parent 560087 b26b22a60f3669b28ee4b5d93c31ab07a3856404
child 560089 519c764753f32d06554720705f4293852708da37
push id38017
push usercbrindusan@mozilla.com
push dateThu, 10 Dec 2020 03:47:02 +0000
treeherdermozilla-central@7b5facb4df3a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersremote-protocol-reviewers, desktop-theme-reviewers, ntim
bugs1654684
milestone85.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1654684 - Move chevron.svg to toolkit. r=remote-protocol-reviewers,desktop-theme-reviewers,ntim Differential Revision: https://phabricator.services.mozilla.com/D97394
browser/base/content/test/performance/browser_startup_images.js
browser/themes/shared/icons/chevron.svg
browser/themes/shared/jar.inc.mn
browser/themes/shared/toolbarbutton-icons.inc.css
docshell/test/chrome/test_bug909218.html
remote/test/browser/network/browser_setCacheDisabled.js
toolkit/themes/shared/icons/chevron.svg
toolkit/themes/shared/jar.inc.mn
--- a/browser/base/content/test/performance/browser_startup_images.js
+++ b/browser/base/content/test/performance/browser_startup_images.js
@@ -47,17 +47,17 @@ const knownUnshownImages = [
   },
   {
     file: "resource://gre-resources/broken-image.png",
     platforms: ["win", "macosx"],
     intermittentNotLoaded: ["win", "macosx"],
   },
 
   {
-    file: "chrome://browser/skin/chevron.svg",
+    file: "chrome://global/skin/icons/chevron.svg",
     platforms: ["win", "linux", "macosx"],
     intermittentShown: ["win", "linux"],
   },
 
   {
     file: "chrome://browser/skin/window-controls/maximize.svg",
     platforms: ["win"],
     // This is to prevent perma-fails in case Windows machines
--- a/browser/themes/shared/jar.inc.mn
+++ b/browser/themes/shared/jar.inc.mn
@@ -168,17 +168,16 @@
   skin/classic/browser/back-12.svg                    (../shared/icons/back-12.svg)
   skin/classic/browser/bookmark.svg                   (../shared/icons/bookmark.svg)
   skin/classic/browser/bookmark-12.svg                (../shared/icons/bookmark-12.svg)
   skin/classic/browser/bookmark-animation.svg         (../shared/icons/bookmark-animation.svg)
   skin/classic/browser/bookmark-hollow.svg            (../shared/icons/bookmark-hollow.svg)
   skin/classic/browser/bookmark-star-on-tray.svg      (../shared/icons/bookmark-star-on-tray.svg)
   skin/classic/browser/bookmarks-toolbar.svg          (../shared/icons/bookmarks-toolbar.svg)
   skin/classic/browser/characterEncoding.svg          (../shared/icons/characterEncoding.svg)
-  skin/classic/browser/chevron.svg                    (../shared/icons/chevron.svg)
   skin/classic/browser/chevron-animation.svg          (../shared/icons/chevron-animation.svg)
   skin/classic/browser/check-animation.svg            (../shared/icons/check-animation.svg)
   skin/classic/browser/customize.svg                  (../shared/icons/customize.svg)
   skin/classic/browser/developer.svg                  (../shared/icons/developer.svg)
   skin/classic/browser/device-phone.svg               (../shared/icons/device-phone.svg)
   skin/classic/browser/device-tablet.svg              (../shared/icons/device-tablet.svg)
   skin/classic/browser/device-desktop.svg             (../shared/icons/device-desktop.svg)
   skin/classic/browser/device-tv.svg                  (../shared/icons/device-tv.svg)
--- a/browser/themes/shared/toolbarbutton-icons.inc.css
+++ b/browser/themes/shared/toolbarbutton-icons.inc.css
@@ -323,17 +323,17 @@ toolbar[brighttext] {
 }
 
 #zoom-in-button {
   list-style-image: url("chrome://browser/skin/zoom-in.svg");
 }
 
 #PlacesChevron,
 #nav-bar-overflow-button {
-  list-style-image: url("chrome://browser/skin/chevron.svg");
+  list-style-image: url("chrome://global/skin/icons/chevron.svg");
 }
 
 #nav-bar-overflow-button[animate] > .toolbarbutton-icon {
   fill: transparent;
 }
 
 @keyframes overflow-animation {
   from {
--- a/docshell/test/chrome/test_bug909218.html
+++ b/docshell/test/chrome/test_bug909218.html
@@ -87,17 +87,17 @@ var RequestWatcher = {
     // We are checking requests - if there isn't one, ignore it.
     if (!req) {
       return;
     }
     // We will usually see requests for 'about:document-onload-blocker' not
     // have the flag, so we just ignore them.
     // We also see, eg, resource://gre-resources/loading-image.png, so
     // skip resource:// URLs too.
-    // We may also see, eg, chrome://browser/skin/chevron.svg, so
+    // We may also see, eg, chrome://global/skin/icons/chevron.svg, so
     // skip chrome:// URLs too.
     if (req.name.startsWith("about:") || req.name.startsWith("resource:") ||
         req.name.startsWith("chrome:") || req.name.startsWith("documentchannel:")) {
       return;
     }
     is(req.loadFlags & TEST_FLAGS, TEST_FLAGS, "request " + req.name + " has the expected flags");
     this.requestCounts[req.name] += 1;
     var stopFlags = Ci.nsIWebProgressListener.STATE_STOP |
--- a/remote/test/browser/network/browser_setCacheDisabled.js
+++ b/remote/test/browser/network/browser_setCacheDisabled.js
@@ -73,17 +73,17 @@ function checkLoadFlags(flags, url) {
           if (!request) {
             return;
           }
 
           // We will usually see requests for 'about:document-onload-blocker' not
           // have the flag, so we just ignore them.
           // We also see, eg, resource://gre-resources/loading-image.png, so
           // skip resource:// URLs too.
-          // We may also see, eg, chrome://browser/skin/chevron.svg, so
+          // We may also see, eg, chrome://global/skin/icons/chevron.svg, so
           // skip chrome:// URLs too.
           if (
             request.name.startsWith("about:") ||
             request.name.startsWith("resource:") ||
             request.name.startsWith("chrome:")
           ) {
             return;
           }
rename from browser/themes/shared/icons/chevron.svg
rename to toolkit/themes/shared/icons/chevron.svg
--- a/toolkit/themes/shared/jar.inc.mn
+++ b/toolkit/themes/shared/jar.inc.mn
@@ -30,16 +30,17 @@ toolkit.jar:
   skin/classic/global/numberinput.css                      (../../shared/numberinput.css)
   skin/classic/global/in-content/toggle-button.css         (../../shared/in-content/toggle-button.css)
   skin/classic/global/icons/arrow-left.svg                 (../../shared/icons/arrow-left.svg)
   skin/classic/global/icons/autoscroll.svg                 (../../shared/icons/autoscroll.svg)
   skin/classic/global/icons/autoscroll-horizontal.svg      (../../shared/icons/autoscroll-horizontal.svg)
   skin/classic/global/icons/autoscroll-vertical.svg        (../../shared/icons/autoscroll-vertical.svg)
   skin/classic/global/icons/check.svg                      (../../shared/icons/check.svg)
   skin/classic/global/icons/check-partial.svg              (../../shared/icons/check-partial.svg)
+  skin/classic/global/icons/chevron.svg                    (../../shared/icons/chevron.svg)
   skin/classic/global/icons/close.svg                      (../../shared/icons/close.svg)
   skin/classic/global/icons/searchfield-cancel.svg         (../../shared/icons/searchfield-cancel.svg)
   skin/classic/global/pictureinpicture/close-pip.svg       (../../shared/pictureinpicture/close-pip.svg)
   skin/classic/global/icons/columnpicker.svg               (../../shared/icons/columnpicker.svg)
   skin/classic/global/icons/delete.svg                     (../../shared/icons/delete.svg)
   skin/classic/global/icons/document.svg                   (../../shared/icons/document.svg)
   skin/classic/global/icons/error.svg                      (../../shared/icons/error.svg)
   skin/classic/global/icons/find-previous-arrow.svg        (../../shared/icons/find-previous-arrow.svg)