Bug 691647 Part 1: clean up nsISidebar interface by removing the non-standard addPersistentPanel/addPanel methods, and adjusting method arguments to avoid the use of string/wstring. r=jst, sr=sicking
authorGavin Sharp <gavin@gavinsharp.com>
Mon, 08 Apr 2013 19:22:48 -0700
changeset 128103 3f2095fd4fc94ce3667506a6811037d0548c25e7
parent 128102 bc8c31010d962c14842eb3bba55992a5a5a21bd6
child 128104 bcdc2f3743f947c9f6317af2b7248ee2e0c6fbd5
push id24520
push useremorley@mozilla.com
push dateTue, 09 Apr 2013 09:06:14 +0000
treeherdermozilla-central@d09a5a5666ba [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjst, sicking
bugs691647
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 691647 Part 1: clean up nsISidebar interface by removing the non-standard addPersistentPanel/addPanel methods, and adjusting method arguments to avoid the use of string/wstring. r=jst, sr=sicking
dom/interfaces/sidebar/nsISidebar.idl
--- a/dom/interfaces/sidebar/nsISidebar.idl
+++ b/dom/interfaces/sidebar/nsISidebar.idl
@@ -1,45 +1,29 @@
 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-/*
-
-  The Sidebar API for 3rd parties
-
-*/
-
 #include "nsISupports.idl"
 
-[scriptable, uuid(41a22fb6-39e2-45e1-95c5-7e8cea36575d)]
+[scriptable, uuid(351887ca-56b2-4458-96fc-88baeb57b6e7)]
 interface nsISidebar : nsISupports
 {
-    void addPanel(in wstring aTitle, in string aContentURL,
-                  in string aCustomizeURL);
-    void addPersistentPanel(in wstring aTitle, in string aContentURL,
-                            in string aCustomizeURL);
-    void addSearchEngine(in string engineURL, in string iconURL,
-                         in wstring suggestedTitle, in wstring suggestedCategory);
+  void addSearchEngine(in DOMString engineURL, in DOMString iconURL,
+                       in DOMString suggestedTitle, in DOMString suggestedCategory);
 };
 
-[scriptable, uuid(4350fb73-9305-41df-a669-11d26222d420)]
+[scriptable, uuid(5895076f-e28e-434a-9fdb-a69f94eb323f)]
 interface nsISidebarExternal : nsISupports
 {
-    void AddSearchProvider(in string aDescriptionURL);
-		unsigned long IsSearchProviderInstalled(in string aSearchURL);
+  void AddSearchProvider(in DOMString aDescriptionURL);
+  unsigned long IsSearchProviderInstalled(in DOMString aSearchURL);
 };
 
 %{ C++
 // {577CB744-8CAF-11d3-AAEF-00805F8A4905} 
 #define NS_SIDEBAR_CID \
 { 0x577cb744, 0x8caf, 0x11d3, { 0xaa, 0xef, 0x0, 0x80, 0x5f, 0x8a, 0x49, 0x5 } }
 
 #define NS_SIDEBAR_CONTRACTID "@mozilla.org/sidebar;1"
 %}
-
-/*
- var isidebar = Components.interfaces.nsISidebar;
- var csidebar = Components.classes['@mozilla.org/sidebar;1'];
- var sidebar = csidebar.createInstance(isidebar);
-*/