Bug 1301068: Ensure InputExhausted is called if H264Converter drops a frame. r=gerald
authorJean-Yves Avenard <jyavenard@mozilla.com>
Thu, 08 Sep 2016 00:22:06 +1000
changeset 313109 3e3c5cd9d31eaa0fed88b46297ace3590613589c
parent 313108 ba7d7fe0ea3cafb1b27e738dfa3697eb3f49dec7
child 313110 92f041a22d0a2f11d95453b0934fee8d3e9b6529
push id30671
push usercbook@mozilla.com
push dateThu, 08 Sep 2016 09:59:51 +0000
treeherdermozilla-central@bd28be90aed8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgerald
bugs1301068
milestone51.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1301068: Ensure InputExhausted is called if H264Converter drops a frame. r=gerald MozReview-Commit-ID: LyZlzU4D58o
dom/media/platforms/wrappers/H264Converter.cpp
--- a/dom/media/platforms/wrappers/H264Converter.cpp
+++ b/dom/media/platforms/wrappers/H264Converter.cpp
@@ -75,16 +75,17 @@ H264Converter::Input(MediaRawData* aSamp
   if (!mDecoder) {
     // It is not possible to create an AVCC H264 decoder without SPS.
     // As such, creation will fail if the extra_data just extracted doesn't
     // contain a SPS.
     rv = CreateDecoderAndInit(aSample);
     if (rv == NS_ERROR_NOT_INITIALIZED) {
       // We are missing the required SPS to create the decoder.
       // Ignore for the time being, the MediaRawData will be dropped.
+      mCallback->InputExhausted();
       return NS_OK;
     }
   } else {
     rv = CheckForSPSChange(aSample);
   }
   NS_ENSURE_SUCCESS(rv, rv);
 
   if (mNeedKeyframe && !aSample->mKeyframe) {