Bug 525221 - Loop over DIRS better in NSPR, r=ted
☠☠ backed out by e8f791a62494 ☠ ☠
authorBenjamin Smedberg <benjamin@smedbergs.us>
Mon, 09 Nov 2009 13:47:29 -0500
changeset 34730 3e1290bba9029798016d7106237fea5850f8840c
parent 34729 350ffc1d793a3f77bb015771917280091c92903f
child 34731 f1975d08b880b426e7765e6db7b0e3556c8bc542
child 34732 e8f791a62494b867be1757d44fe4e045afd406d6
push id10210
push userbsmedberg@mozilla.com
push dateTue, 10 Nov 2009 14:50:41 +0000
treeherdermozilla-central@f1975d08b880 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs525221
milestone1.9.3a1pre
Bug 525221 - Loop over DIRS better in NSPR, r=ted
nsprpub/config/rules.mk
--- a/nsprpub/config/rules.mk
+++ b/nsprpub/config/rules.mk
@@ -167,28 +167,23 @@ endif
 ALL_TRASH		= $(TARGETS) $(OBJS) $(RES) $(filter-out . .., $(OBJDIR)) LOGS TAGS $(GARBAGE) \
 			  $(NOSUCHFILE) \
 			  so_locations
 
 ifndef RELEASE_LIBS_DEST
 RELEASE_LIBS_DEST	= $(RELEASE_LIB_DIR)
 endif
 
+define MAKE_DIR
+	$(MAKE) -C $(dir) $@
+
+endef
+
 ifdef DIRS
-LOOP_OVER_DIRS		=					\
-	@for d in $(DIRS); do					\
-		if test -d $$d; then				\
-			set -e;					\
-			echo "cd $$d; $(MAKE) $@";		\
-			$(MAKE) -C $$d $@;			\
-			set +e;					\
-		else						\
-			echo "Skipping non-directory $$d...";	\
-		fi;						\
-	done
+LOOP_OVER_DIRS = $(foreach dir,$(wildcard $(DIRS)),$(MAKE_DIR))
 endif
 
 ################################################################################
 
 all:: export
 
 export::
 	+$(LOOP_OVER_DIRS)