Bug 1282795 - Make JS::CompileOptions final to silence some -Wdelete-non-virtual-dtor warnings caused by Maybe<JS::CompileOptions>. r=froydnj
authorJeff Walden <jwalden@mit.edu>
Tue, 28 Jun 2016 17:09:18 +0100
changeset 303075 3decbf5a262fa0fdb28417c165800402c385fbc5
parent 303074 2733f167b8cd6f5c2ce2713f08ebb5e2511a77df
child 303076 94cb0c8e7febc61770904fca83ae56c86e5ee43b
push id30379
push usercbook@mozilla.com
push dateWed, 29 Jun 2016 14:13:35 +0000
treeherdermozilla-central@b69a5bbb5e40 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1282795
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1282795 - Make JS::CompileOptions final to silence some -Wdelete-non-virtual-dtor warnings caused by Maybe<JS::CompileOptions>. r=froydnj
js/src/jsapi.h
--- a/js/src/jsapi.h
+++ b/js/src/jsapi.h
@@ -3892,17 +3892,17 @@ class JS_FRIEND_API(OwningCompileOptions
 
 /**
  * Compilation options stored on the stack. An instance of this type
  * simply holds references to dynamically allocated resources (element;
  * filename; source map URL) that are owned by something else. If you
  * create an instance of this type, it's up to you to guarantee that
  * everything you store in it will outlive it.
  */
-class MOZ_STACK_CLASS JS_FRIEND_API(CompileOptions) : public ReadOnlyCompileOptions
+class MOZ_STACK_CLASS JS_FRIEND_API(CompileOptions) final : public ReadOnlyCompileOptions
 {
     RootedObject elementRoot;
     RootedString elementAttributeNameRoot;
     RootedScript introductionScriptRoot;
 
   public:
     explicit CompileOptions(JSContext* cx, JSVersion version = JSVERSION_UNKNOWN);
     CompileOptions(js::ContextFriendFields* cx, const ReadOnlyCompileOptions& rhs)