Bug 1583614: Def on frameloader rebuilding on remoteness change again. r=mattwoodrow
authorKris Maglione <maglione.k@gmail.com>
Thu, 05 Dec 2019 03:52:49 +0000
changeset 505573 3dc70a33491f26ffcd6c7bdf4e9d7a8b2e052e4e
parent 505572 958f25e0cae235999026bf83e7af2a113c9a1605
child 505574 493c6741ff3e09d1f12c0a835540cfa6dd8d9cb2
push id36884
push useropoprus@mozilla.com
push dateThu, 05 Dec 2019 09:46:49 +0000
treeherdermozilla-central@3dc70a33491f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmattwoodrow
bugs1583614
milestone73.0a1
first release with
nightly linux32
3dc70a33491f / 73.0a1 / 20191205094649 / files
nightly linux64
3dc70a33491f / 73.0a1 / 20191205094649 / files
nightly mac
3dc70a33491f / 73.0a1 / 20191205094649 / files
nightly win32
3dc70a33491f / 73.0a1 / 20191205094649 / files
nightly win64
3dc70a33491f / 73.0a1 / 20191205094649 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1583614: Def on frameloader rebuilding on remoteness change again. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D55858
browser/components/sessionstore/test/browser_multiple_navigateAndRestore.js
browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js
modules/libpref/init/all.js
--- a/browser/components/sessionstore/test/browser_multiple_navigateAndRestore.js
+++ b/browser/components/sessionstore/test/browser_multiple_navigateAndRestore.js
@@ -13,17 +13,17 @@ add_task(async function() {
   gBrowser.selectedTab = tab;
   let browser = gBrowser.selectedBrowser;
   ok(!browser.isRemoteBrowser, "Ensure browser is not remote");
   // Load a remote page, and then another remote page immediately
   // after.
   BrowserTestUtils.loadURI(browser, PAGE_1);
   browser.stop();
   BrowserTestUtils.loadURI(browser, PAGE_2);
-  await BrowserTestUtils.browserLoaded(browser);
+  await BrowserTestUtils.browserLoaded(browser, false, PAGE_2);
 
   ok(browser.isRemoteBrowser, "Should have switched remoteness");
   await TabStateFlusher.flush(browser);
   let state = JSON.parse(ss.getTabState(tab));
   let entries = state.entries;
   is(entries.length, 1, "There should only be one entry");
   is(entries[0].url, PAGE_2, "Should have PAGE_2 as the sole history entry");
   is(
--- a/browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js
+++ b/browser/components/urlbar/tests/browser/browser_urlbar_event_telemetry.js
@@ -234,19 +234,24 @@ const tests = [
         selType: "canonized",
       },
     };
   },
 
   async function() {
     info("Type something, click on bookmark entry.");
     gURLBar.select();
-    let promise = BrowserTestUtils.browserLoaded(gBrowser.selectedBrowser);
+    let url = "http://example.com/?q=%s";
+    let promise = BrowserTestUtils.browserLoaded(
+      gBrowser.selectedBrowser,
+      false,
+      url
+    );
     await promiseAutocompleteResultPopup("exa", window, true);
-    while (gURLBar.untrimmedValue != "http://example.com/?q=%s") {
+    while (gURLBar.untrimmedValue != url) {
       EventUtils.synthesizeKey("KEY_ArrowDown");
     }
     let element = UrlbarTestUtils.getSelectedRow(window);
     EventUtils.synthesizeMouseAtCenter(element, {});
     await promise;
     return {
       category: "urlbar",
       method: "engagement",
--- a/modules/libpref/init/all.js
+++ b/modules/libpref/init/all.js
@@ -4678,19 +4678,17 @@ pref("general.document_open_conversion_d
 pref("dom.event.default_to_passive_touch_listeners", true);
 
 // Should only be enabled in tests
 pref("dom.events.testing.asyncClipboard", false);
 
 // Disable moz* APIs in DataTransfer
 pref("dom.datatransfer.mozAtAPIs", false);
 
-// Bug 1583614: This is on by default for Fission windows, but still
-// causes enough issues to prevent us from turning it on everywhere.
-pref("fission.rebuild_frameloaders_on_remoteness_change", false);
+pref("fission.rebuild_frameloaders_on_remoteness_change", true);
 
 // Support for legacy customizations that rely on checking the
 // user profile directory for these stylesheets:
 //  * userContent.css
 //  * userChrome.css
 pref("toolkit.legacyUserProfileCustomizations.stylesheets", false);
 
 #ifdef MOZ_DATA_REPORTING