Bug 1733552 - Expose about:welcome colorway variation names for localization r=pdahiya,fluent-reviewers,flod
authorEd Lee <edilee@mozilla.com>
Fri, 01 Oct 2021 15:58:44 +0000
changeset 593946 3da25d6e8dbfd432754c55e9aa5e2f2a1fcb0ac6
parent 593945 c4b7ed3e820f0b936d8e3f12ac142b6319550d2f
child 593947 4a128faef4728890597d74ed745e9d16f4b500a2
push id38838
push userimoraru@mozilla.com
push dateFri, 01 Oct 2021 21:46:01 +0000
treeherdermozilla-central@60b737e0dbfb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspdahiya, fluent-reviewers, flod
bugs1733552
milestone94.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1733552 - Expose about:welcome colorway variation names for localization r=pdahiya,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D127254
browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm
browser/locales/en-US/browser/newtab/onboarding.ftl
--- a/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm
+++ b/browser/components/newtab/aboutwelcome/lib/AboutWelcomeDefaults.jsm
@@ -183,37 +183,43 @@ const DEFAULT_WELCOME_CONTENT = {
               description: {
                 string_id: "mr1-onboarding-theme-description-dark",
               },
             },
           ],
           variations: [
             {
               id: "soft",
-              label: "Soft",
+              label: {
+                string_id: "mr2-onboarding-colorway-label-soft",
+              },
               tooltip: {
                 string_id: "mr2-onboarding-theme-tooltip",
               },
               description: {
                 string_id: "mr2-onboarding-theme-description",
               },
             },
             {
               id: "balanced",
-              label: "Balanced",
+              label: {
+                string_id: "mr2-onboarding-colorway-label-balanced",
+              },
               tooltip: {
                 string_id: "mr2-onboarding-theme-tooltip",
               },
               description: {
                 string_id: "mr2-onboarding-theme-description",
               },
             },
             {
               id: "bold",
-              label: "Bold",
+              label: {
+                string_id: "mr2-onboarding-colorway-label-bold",
+              },
               tooltip: {
                 string_id: "mr2-onboarding-theme-tooltip",
               },
               description: {
                 string_id: "mr2-onboarding-theme-description",
               },
             },
           ],
--- a/browser/locales/en-US/browser/newtab/onboarding.ftl
+++ b/browser/locales/en-US/browser/newtab/onboarding.ftl
@@ -105,16 +105,21 @@ mr1-onboarding-import-primary-button-lab
 # This string will be used in cases where we can't detect the previous browser name.
 mr1-onboarding-import-primary-button-label-no-attribution = Import from previous browser
 mr1-onboarding-import-secondary-button-label = Not now
 
 mr2-onboarding-colorway-header = Life in color
 mr2-onboarding-colorway-subtitle = Vibrant new colorways. Available for a limited time.
 mr2-onboarding-colorway-primary-button-label = Save colorway
 mr2-onboarding-colorway-secondary-button-label = Not now
+mr2-onboarding-colorway-label-soft = Soft
+mr2-onboarding-colorway-label-balanced = Balanced
+# "Bold" is used in the sense of bravery or courage, not in the sense of
+# emphasized text.
+mr2-onboarding-colorway-label-bold = Bold
 
 # Automatic theme uses operating system color settings
 mr2-onboarding-theme-label-auto = Auto
 
 # This string will be used for Default theme
 mr2-onboarding-theme-label-default = Default
 
 mr1-onboarding-theme-header = Make it your own