Bug 1725973 Part 1 - Add a FLEX_LOG in MoveFlexItemToFinalPosition(). r=dholbert
authorTing-Yu Lin <tlin@mozilla.com>
Thu, 26 Aug 2021 22:43:09 +0000
changeset 590088 3bbec943b9a4fcf84f917e682ba54a56046196eb
parent 590087 775e23b5bf529e5a752215d9498459951df7edc2
child 590089 4fcd1b02c5bdfdb3d4e9b8d8b93289f81c638981
push id38740
push usermalexandru@mozilla.com
push dateFri, 27 Aug 2021 03:42:22 +0000
treeherdermozilla-central@ab80197101b9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1725973
milestone93.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1725973 Part 1 - Add a FLEX_LOG in MoveFlexItemToFinalPosition(). r=dholbert Make it easier to spot a flex item is being moved to the final position rather than going through the final reflow. Differential Revision: https://phabricator.services.mozilla.com/D123702
layout/generic/nsFlexContainerFrame.cpp
--- a/layout/generic/nsFlexContainerFrame.cpp
+++ b/layout/generic/nsFlexContainerFrame.cpp
@@ -5489,16 +5489,19 @@ void nsFlexContainerFrame::PopulateReflo
 
   // Convert flex container's final desired size to parent's WM, for outparam.
   aReflowOutput.SetSize(flexWM, desiredSizeInFlexWM);
 }
 
 void nsFlexContainerFrame::MoveFlexItemToFinalPosition(
     const ReflowInput& aReflowInput, const FlexItem& aItem,
     LogicalPoint& aFramePos, const nsSize& aContainerSize) {
+  FLEX_LOG("Moving flex item %p to its desired position %s", aItem.Frame(),
+           ToString(aFramePos).c_str());
+
   WritingMode outerWM = aReflowInput.GetWritingMode();
 
   // If item is relpos, look up its offsets (cached from prev reflow)
   LogicalMargin logicalOffsets(outerWM);
   if (StylePositionProperty::Relative ==
       aItem.Frame()->StyleDisplay()->mPosition) {
     nsMargin* cachedOffsets =
         aItem.Frame()->GetProperty(nsIFrame::ComputedOffsetProperty());