Bug 1210774 - Upgrade Loop's use of eslint (to 1.6.x) and eslint-plugin-react (to 3.5.x). r=Mardak NPOTB DONTBUILD
authorMark Banner <standard8@mozilla.com>
Fri, 16 Oct 2015 10:31:06 +0100
changeset 268001 3b9e4b34d1593c59e46a836504da0ad2221e91bf
parent 268000 1b3332a397444387ef2180ed9a26a683b41f6e0e
child 268002 398514bdc83f86704dc7a4e29b07fe1f66f1b8a5
push id29537
push userkwierso@gmail.com
push dateFri, 16 Oct 2015 18:36:26 +0000
treeherdermozilla-central@3da0fdd88673 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMardak
bugs1210774
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1210774 - Upgrade Loop's use of eslint (to 1.6.x) and eslint-plugin-react (to 3.5.x). r=Mardak NPOTB DONTBUILD
browser/components/loop/.eslintrc
browser/components/loop/standalone/package.json
--- a/browser/components/loop/.eslintrc
+++ b/browser/components/loop/.eslintrc
@@ -39,16 +39,17 @@
     "camelcase": 0,               // TODO: set to 2
     "comma-spacing": 2,
     "computed-property-spacing": [2, "never"],
     "consistent-return": 0,       // TODO: set to 2
     "curly": [2, "all"],
     "dot-location": [2, "property"],
     "eol-last": 2,
     "eqeqeq": [2, "smart"],
+    "jsx-quotes": [2, "prefer-double"],
     "key-spacing": [2, {"beforeColon": false, "afterColon": true }],
     "linebreak-style": [2, "unix"],
     "new-cap": 0,                 // TODO: set to 2
     "new-parens": 2,
     "no-alert": 2,
     "no-array-constructor": 2,
     "no-caller": 2,
     "no-catch-shadow": 0,         // TODO: set to 2
@@ -101,17 +102,16 @@
     "space-infix-ops": 2,
     "space-return-throw-case": 2,
     "space-unary-ops": [2, {"words": true, "nonwords": false}],
     "spaced-comment": [2, "always"],
     "strict": [2, "function"],
     "yoda": [2, "never"],
     // eslint-plugin-react rules. These are documented at
     // <https://github.com/yannickcr/eslint-plugin-react#list-of-supported-rules>
-    "react/jsx-quotes": [2, "double", "avoid-escape"],
     "react/jsx-no-undef": 2,
     "react/jsx-sort-props": 2,
     "react/jsx-sort-prop-types": 2,
     "react/jsx-uses-vars": 2,
     "react/jsx-no-duplicate-props": 2,
     // Need to fix the couple of instances which don't
     // currently pass this rule.
     "react/no-did-mount-set-state": 0,
--- a/browser/components/loop/standalone/package.json
+++ b/browser/components/loop/standalone/package.json
@@ -8,19 +8,19 @@
   },
   "engines": {
     "node": "0.10.x",
     "npm": "1.3.x"
   },
   "dependencies": {},
   "devDependencies": {
     "compression": "1.5.x",
-    "eslint": "1.2.x",
+    "eslint": "1.6.x",
     "eslint-plugin-mozilla": "../../../../testing/eslint-plugin-mozilla",
-    "eslint-plugin-react": "3.2.x",
+    "eslint-plugin-react": "3.5.x",
     "exports-loader": "0.6.x",
     "express": "4.x",
     "imports-loader": "0.6.x",
     "script-loader": "0.6.x",
     "webpack": "1.12.x"
   },
   "scripts": {
     "test": "make test",