Bug 1573817: Remove unused parameter in EffectiveCores; r=lth
authorBenjamin Bouvier <benj@benj.me>
Wed, 14 Aug 2019 18:54:29 +0000
changeset 488473 3b5ed7e00e3b1fcfdcabfaea7336a3989ba47143
parent 488472 c07f3a9fa9b77fc6f1a132c59ef8099195e0c46a
child 488474 85cea8a5afb8131949932fbba97b5542bdc2d54c
push id36444
push userccoroiu@mozilla.com
push dateFri, 16 Aug 2019 16:24:18 +0000
treeherdermozilla-central@8a9e9189cd98 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerslth
bugs1573817
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1573817: Remove unused parameter in EffectiveCores; r=lth Differential Revision: https://phabricator.services.mozilla.com/D41966
js/src/wasm/WasmCompile.cpp
--- a/js/src/wasm/WasmCompile.cpp
+++ b/js/src/wasm/WasmCompile.cpp
@@ -340,17 +340,17 @@ static double CodesizeCutoff(SystemClass
 //
 // The data are empirical, computed from the observed compilation time of the
 // Tanks demo code on a variable number of cores.
 //
 // The heuristic may fail on NUMA systems where the core count is high but the
 // performance increase is nil or negative once the program moves beyond one
 // socket.  However, few browser users have such systems.
 
-static double EffectiveCores(SystemClass cls, uint32_t cores) {
+static double EffectiveCores(uint32_t cores) {
   if (cores <= 3) {
     return pow(cores, 0.9);
   }
   return pow(cores, 0.75);
 }
 
 #ifndef JS_64BIT
 // Don't tier if tiering will fill code memory to more to more than this
@@ -388,17 +388,17 @@ static bool TieringBeneficial(uint32_t c
   uint32_t cores = Min(cpuCount, workers);
 
   SystemClass cls = ClassifySystem();
 
   // Ion compilation on available cores must take long enough to be worth the
   // bother.
 
   double cutoffSize = CodesizeCutoff(cls);
-  double effectiveCores = EffectiveCores(cls, cores);
+  double effectiveCores = EffectiveCores(cores);
 
   if ((codeSize / effectiveCores) < cutoffSize) {
     return false;
   }
 
   // Do not implement a size cutoff for 64-bit systems since the code size
   // budget for 64 bit is so large that it will hardly ever be an issue.
   // (Also the cutoff percentage might be different on 64-bit.)