Bug 1369140 - Part 6: Adjust the last few reflow tests to reflect reality. r=bustage-fix on a CLOSED TREE
authorMike Conley <mconley@mozilla.com>
Thu, 01 Jun 2017 11:37:31 -0400
changeset 361867 3b2d0ff5f9a365be1e57e1c8b11d11f43ea169d0
parent 361866 098b03dbc0c2b20fa498a3588f920059a8846e5b
child 361868 d92e242ec5f184c0e0eeafa58ef8a3301456a981
push id31946
push userryanvm@gmail.com
push dateThu, 01 Jun 2017 20:43:38 +0000
treeherdermozilla-central@b138d2f271fd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage-fix
bugs1369140
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1369140 - Part 6: Adjust the last few reflow tests to reflect reality. r=bustage-fix on a CLOSED TREE MozReview-Commit-ID: 4mVMX4GzZ7X
browser/base/content/test/performance/browser_tabopen_reflows.js
browser/base/content/test/performance/browser_windowopen_reflows.js
--- a/browser/base/content/test/performance/browser_tabopen_reflows.js
+++ b/browser/base/content/test/performance/browser_tabopen_reflows.js
@@ -13,26 +13,16 @@
  * for tips on how to do that.
  */
 const EXPECTED_REFLOWS = [
   // selection change notification may cause querying the focused editor content
   // by IME and that will cause reflow.
   [
     "select@chrome://global/content/bindings/textbox.xml",
   ],
-
-  // selection change notification may cause querying the focused editor content
-  // by IME and that will cause reflow.
-  [
-    "select@chrome://global/content/bindings/textbox.xml",
-  ],
-
-  [
-    "select@chrome://global/content/bindings/textbox.xml",
-  ],
 ];
 
 /*
  * This test ensures that there are no unexpected
  * uninterruptible reflows when opening new tabs.
  */
 add_task(async function() {
   // If we've got a preloaded browser, get rid of it so that it
--- a/browser/base/content/test/performance/browser_windowopen_reflows.js
+++ b/browser/base/content/test/performance/browser_windowopen_reflows.js
@@ -8,25 +8,19 @@
  * is a whitelist that should slowly go away as we improve the performance of
  * the front-end. Instead of adding more reflows to the whitelist, you should
  * be modifying your code to avoid the reflow.
  *
  * See https://developer.mozilla.org/en-US/Firefox/Performance_best_practices_for_Firefox_fe_engineers
  * for tips on how to do that.
  */
 const EXPECTED_REFLOWS = [
-  // Selecting the address bar causes two reflows, unfortunately.
   [
     "select@chrome://global/content/bindings/textbox.xml",
-    "_delayedStartup@chrome://browser/content/browser.js",
-  ],
-
-  // Selecting the address bar causes two reflows, unfortunately.
-  [
-    "select@chrome://global/content/bindings/textbox.xml",
+    "focusAndSelectUrlBar@chrome://browser/content/browser.js",
     "_delayedStartup@chrome://browser/content/browser.js",
   ],
 ];
 
 if (Services.appinfo.OS == "Darwin") {
   // TabsInTitlebar._update causes a reflow on OS X trying to do calculations
   // since layout info is already dirty. This doesn't seem to happen before
   // MozAfterPaint on Linux.