Bug 1545639 [wpt PR 16353] - Revert "Fix error message for deleteRule()", a=testonly
authorMason Freed <masonfreed@chromium.org>
Fri, 17 May 2019 14:35:55 +0000
changeset 477195 3ab7ec36c060523f9144e55d91fd8732333374d4
parent 477194 8eceb2466c289b394426737eaca0c48f77220e87
child 477196 bfc2b080062651470a37354d8a8ec18dd617dc8d
push id36116
push usershindli@mozilla.com
push dateThu, 06 Jun 2019 10:00:05 +0000
treeherdermozilla-central@fee989d27558 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1545639, 16353, 949523, 1561410, 650697, 1566836, 650835
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1545639 [wpt PR 16353] - Revert "Fix error message for deleteRule()", a=testonly Automatic update from web-platform-tests Revert "Fix error message for deleteRule()" This reverts commit b2caae9ede888ede7d662c8760da9ab765904571. Reason for revert: Reverting while I get more context on the deprecation of IndexSizeError Original change's description: > Fix error message for deleteRule() > > Previous to this CL, deleteRule on an empty style sheet would throw a > confusingly-worded IndexSizeError. Now, it properly throws a RangeError. > > For example: > > const styleEl = document.createElement('style'); > document.head.appendChild(styleEl); > styleEl.sheet.deleteRule(0); > --> Uncaught RangeError: Failed to execute 'deleteRule' on 'CSSStyleSheet': The index provided (0) is outside the range [0, 0). > > Bug: 949523 > Change-Id: I306409f53be88f4bead261dd171466fd3aad5565 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561410 > Auto-Submit: Mason Freed <masonfreed@chromium.org> > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650697} TBR=chrishtr@chromium.org,masonfreed@chromium.org Change-Id: I773160a6ffa263dd7b8d2eb9c9025ad46a970044 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566836 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#650835} -- wpt-commits: 1a9adfc150fb7e048e24f5a2e2f97ba7df340752 wpt-pr: 16353
testing/web-platform/tests/css/cssom/stylesheet-deleterule-error.html
deleted file mode 100644
--- a/testing/web-platform/tests/css/cssom/stylesheet-deleterule-error.html
+++ /dev/null
@@ -1,21 +0,0 @@
-<!DOCTYPE html>
-<meta charset="utf-8">
-<title>CSSStyleSheet.prototype.deleteRule error message</title>
-<link rel="author" title="Mason Freed" href="mailto:masonfreed@chromium.org">
-<link rel="help" href="https://heycam.github.io/webidl/#indexsizeerror">
-<script src="/resources/testharness.js"></script>
-<script src="/resources/testharnessreport.js"></script>
-<div id="log"></div>
-<script>
-test(function () {
-    const styleEl = document.createElement('style');
-    document.head.appendChild(styleEl);
-    try {
-        styleEl.sheet.deleteRule(0);
-        assert_fail("deleteRule on an empty style sheet should throw a RangeError");
-    } catch (e) {
-        assert_equals(e.name,"RangeError");
-        assert_true(e instanceof RangeError);
-    }
-}, 'deleteRule should throw RangeError');
-</script>