Bug 1522067 - Add additional info about commit messages & blocking reviews. r=Ola
authorchampionshuttler <shivams2799@gmail.com>
Mon, 04 Feb 2019 11:03:19 +0000
changeset 456609 3a1f671e95267c76bf6f95915d816ee58a85a836
parent 456608 6d30d431b5d84b7f1e3cd77bda9e1b64359bf30e
child 456610 6059b24342142db033db72eeae6cc39bad7e2b52
push id35496
push userbtara@mozilla.com
push dateMon, 04 Feb 2019 17:36:40 +0000
treeherdermozilla-central@be1beccfb86d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersOla
bugs1522067
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1522067 - Add additional info about commit messages & blocking reviews. r=Ola Add additional info about commit messages and blocking reviews. Differential Revision: https://phabricator.services.mozilla.com/D18490
devtools/docs/contributing/making-prs.md
--- a/devtools/docs/contributing/making-prs.md
+++ b/devtools/docs/contributing/making-prs.md
@@ -3,19 +3,27 @@
 There are two ways of doing this. We'll first explain the recommended version, and then the alternative, which is older, and we don't recommend, but might be handy in some circumstances.
 
 ## Using Phabricator + Differential (RECOMMENDED)
 
 First, commit your changes. For example:
 
 ```bash
 hg add /path/to/file/changed
-hg commit -m "Bug 1234567 - Implement feature XYZ."
+hg commit -m "Bug 1234567 - Implement feature XYZ. r=name,name2!"
 ```
 
+ The commit message explained in detail:
+ - `Bug 1234567` - The number of the bug in bugzilla.
+ - `- Implement feature XYZ.` - The commit message.
+ - `r=name` - The short form to request a review.
+ - `,name2!` - You can have more than one reviewer. The `!` makes the review a *blocking* review (Patch can not land without accepted review). You will also need to add it to the name in the popup after you ran `arc diff`.
+
+ Please note your first commit message will be also the title of your patch in Phabricator. (Don't worry, if something goes wrong. You can still change things in the UI later).
+
 Then create a revision in Differential, using Arcanist (or `moz-phab`):
 
 ```bash
 arc diff
 ```
 
 You'll be taken to an editor to add extra details, although some of them might be prepopulated using the data in the commit message. Make sure the bug number is filled with the right value. You'll also be able to set reviewers here: enter the names you found using the instructions in the [previous step](./code-reviews-find-reviewer.md).