Bug 1635304 [wpt PR 23392] - Remove erroneous named properties object test, a=testonly
authorDomenic Denicola <d@domenic.me>
Wed, 13 May 2020 09:43:09 +0000
changeset 531096 39821a1edb14230215587bc52dca1d9eb2e73811
parent 531095 c05804108bf90105a51e9de886e593e8c8036549
child 531097 c8f89325cf75089d962d5b4aeb502eaaa91a5c9b
push id37435
push userapavel@mozilla.com
push dateWed, 20 May 2020 15:28:23 +0000
treeherdermozilla-central@5415da14ec9a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1635304, 23392, 23391
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1635304 [wpt PR 23392] - Remove erroneous named properties object test, a=testonly Automatic update from web-platform-tests Remove erroneous named properties object test Fixes #23391. -- wpt-commits: d61c071417775c037d9125b8519e972ade047b42 wpt-pr: 23392
testing/web-platform/tests/WebIDL/ecmascript-binding/class-string-named-properties-object.window.js
--- a/testing/web-platform/tests/WebIDL/ecmascript-binding/class-string-named-properties-object.window.js
+++ b/testing/web-platform/tests/WebIDL/ecmascript-binding/class-string-named-properties-object.window.js
@@ -23,20 +23,12 @@ test(t => {
     Object.defineProperty(namedPropertiesObject, Symbol.toStringTag, { value: "WindowProperties" });
   });
 
   Object.defineProperty(namedPropertiesObject, Symbol.toStringTag, { value: "NotWindowProperties" });
   assert_equals(Object.prototype.toString.call(namedPropertiesObject), "[object NotWindowProperties]");
 }, "Object.prototype.toString applied after modifying @@toStringTag");
 
 // Chrome had a bug (https://bugs.chromium.org/p/chromium/issues/detail?id=793406) where if there
-// was no @@toStringTag, it would fall back to a magic class string. This tests that the bug is
-// fixed.
-
-// Note: we cannot null out the prototype of the named properties object per
-// https://heycam.github.io/webidl/#named-properties-object-setprototypeof so we don't have a test that does that.
-
-// This test must be last.
-test(() => {
-  delete namedPropertiesObject[Symbol.toStringTag];
-
-  assert_equals(Object.prototype.toString.call(namedPropertiesObject), "[object EventTarget]", "prototype");
-}, "Object.prototype.toString applied after deleting @@toStringTag");
+// was no @@toStringTag, it would fall back to a magic class string. Tests for this are present in
+// the sibling class-string*.any.js tests. However, the named properties object always fails calls
+// to [[DefineOwnProperty]] or [[SetPrototypeOf]] per the Web IDL spec, so there is no way to
+// trigger the buggy behavior for it.