Bug 1434614 - about:telemetry Allow to navigate the archive with keyboard arrows, r=chutten
authorJeremy Lempereur <jeremy.lempereur@gmail.com>
Sat, 03 Feb 2018 16:05:04 +0100
changeset 402420 38898fac8d0a5cb3d3d3d62c969e5896baff1e58
parent 402419 10de1d82d4ab7c582abef6d662e94985291c0a6d
child 402421 fe4514c84e7ad28e46bad5da93381deb99b177f3
push id33389
push usernbeleuzu@mozilla.com
push dateTue, 06 Feb 2018 09:53:43 +0000
treeherdermozilla-central@25ceb97b5773 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerschutten
bugs1434614
milestone60.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1434614 - about:telemetry Allow to navigate the archive with keyboard arrows, r=chutten The about:telemetry archived ping data selector now handles the Ping Type correctly when navigating with keyboard arrows. MozReview-Commit-ID: ZRNIlgQNzJ
toolkit/content/aboutTelemetry.js
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -510,16 +510,18 @@ var PingPicker = {
     let first = true;
     Array.from(pingSelector.children).forEach((group) => {
       Array.from(group.children).forEach((option) => {
         if (first && option.dataset.type == type) {
           option.selected = true;
           first = false;
         }
         option.hidden = (type != this.TYPE_ALL) && (option.dataset.type != type);
+        // Arrow keys should only iterate over visible options
+        option.disabled = option.hidden;
       });
     });
     this._updateArchivedPingData();
   },
 
   _getSelectedPingName() {
     if (this.viewCurrentPingData) return bundle.GetStringFromName("currentPing");