Bug 1251291 - Tool notices (Take snapshot and Start Recording Performance) should use var(--theme-body-background), r=jsantell
☠☠ backed out by e2c0da4fea78 ☠ ☠
authorVictor Porof <vporof@mozilla.com>
Mon, 21 Mar 2016 10:05:12 +0100
changeset 289569 3810206dc61f099b8eccdd2fa5f4c90d5cd58641
parent 289568 51452ac19164edb8242bb4e8f56ba2548a69f765
child 289570 18d1e993e4a117f1debd95a8fac0e1f21a97a37a
push id30107
push usercbook@mozilla.com
push dateTue, 22 Mar 2016 10:00:23 +0000
treeherdermozilla-central@3587b25bae30 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjsantell
bugs1251291
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1251291 - Tool notices (Take snapshot and Start Recording Performance) should use var(--theme-body-background), r=jsantell
devtools/client/performance/performance-view.js
--- a/devtools/client/performance/performance-view.js
+++ b/devtools/client/performance/performance-view.js
@@ -15,35 +15,41 @@ var PerformanceView = {
   // that the server has support for determining buffer status.
   _bufferStatusSupported: false,
 
   // Mapping of state to selectors for different properties and their values,
   // from the main profiler view. Used in `PerformanceView.setState()`
   states: {
     "unavailable": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#unavailable-notice") },
+      { sel: "#performance-view-content", opt: "hidden", val: () => true },
     ],
     "empty": [
-      { sel: "#performance-view", opt: "selectedPanel", val: () => $("#empty-notice") }
+      { sel: "#performance-view", opt: "selectedPanel", val: () => $("#empty-notice") },
+      { sel: "#performance-view-content", opt: "hidden", val: () => true },
     ],
     "recording": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#performance-view-content") },
-      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#recording-notice") }
+      { sel: "#performance-view-content", opt: "hidden", val: () => false },
+      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#recording-notice") },
     ],
     "console-recording": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#performance-view-content") },
-      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#console-recording-notice") }
+      { sel: "#performance-view-content", opt: "hidden", val: () => false },
+      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#console-recording-notice") },
     ],
     "recorded": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#performance-view-content") },
-      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#details-pane") }
+      { sel: "#performance-view-content", opt: "hidden", val: () => false },
+      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#details-pane") },
     ],
     "loading": [
       { sel: "#performance-view", opt: "selectedPanel", val: () => $("#performance-view-content") },
-      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#loading-notice") }
+      { sel: "#performance-view-content", opt: "hidden", val: () => false },
+      { sel: "#details-pane-container", opt: "selectedPanel", val: () => $("#loading-notice") },
     ]
   },
 
   /**
    * Sets up the view with event binding and main subviews.
    */
   initialize: Task.async(function* () {
     this._recordButton = $("#main-record-button");