Bug 1622699 part 3: Remove accessibility.xpcom.traverse_outerdoc pref. r=yzen
authorJames Teh <jteh@mozilla.com>
Thu, 26 Mar 2020 18:01:37 +0000
changeset 520623 380eb92fd801cf72d4caa01a2761bc7e4c1f9d5f
parent 520622 b6538a37a0cc05129d6ca4a1f7c6ff5aea8fb2a6
child 520624 59814e3789c1f482cf7ff0a694a58aa89b93230c
push id37254
push usernerli@mozilla.com
push dateFri, 27 Mar 2020 04:48:07 +0000
treeherdermozilla-central@2d758b42bd73 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersyzen
bugs1622699
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1622699 part 3: Remove accessibility.xpcom.traverse_outerdoc pref. r=yzen Differential Revision: https://phabricator.services.mozilla.com/D68304
accessible/base/AccessibleOrProxy.cpp
modules/libpref/init/StaticPrefList.yaml
--- a/accessible/base/AccessibleOrProxy.cpp
+++ b/accessible/base/AccessibleOrProxy.cpp
@@ -2,17 +2,16 @@
 /* vim: set ts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "AccessibleOrProxy.h"
 #include "mozilla/a11y/DocAccessibleParent.h"
 #include "mozilla/a11y/OuterDocAccessible.h"
-#include "mozilla/StaticPrefs_accessibility.h"
 
 namespace mozilla {
 namespace a11y {
 
 AccessibleOrProxy AccessibleOrProxy::Parent() const {
   if (IsAccessible()) {
     return AsAccessible()->Parent();
   }
@@ -57,20 +56,17 @@ AccessibleOrProxy AccessibleOrProxy::Chi
     // Accessible::ChildAtPoint stopped at an OuterDocAccessible, since it
     // can't traverse into ProxyAccessibles. Continue the search from childDoc.
     return childDoc->ChildAtPoint(aX, aY, aWhichChild);
   }
   return target;
 }
 
 ProxyAccessible* AccessibleOrProxy::RemoteChildDoc() const {
-  // This pref should be removed once the Dev Tools A11y Panel Fission
-  // groundwork has landed and it has been verified that this doesn't cause
-  // problems.
-  if (!StaticPrefs::accessibility_xpcom_traverse_outerdoc() || IsProxy()) {
+  if (IsProxy()) {
     return nullptr;
   }
   OuterDocAccessible* outerDoc = AsAccessible()->AsOuterDoc();
   if (!outerDoc) {
     return nullptr;
   }
   return outerDoc->RemoteChildDoc();
 }
--- a/modules/libpref/init/StaticPrefList.yaml
+++ b/modules/libpref/init/StaticPrefList.yaml
@@ -179,21 +179,16 @@
   value: false
   mirror: always
 
 - name: accessibility.AOM.enabled
   type: bool
   value: false
   mirror: always
 
-- name: accessibility.xpcom.traverse_outerdoc
-  type: bool
-  value: false
-  mirror: always
-
 #ifdef ANDROID
   #---------------------------------------------------------------------------
   # Prefs starting with "android."
   #---------------------------------------------------------------------------
 
   # On Android, we want an opaque background to be visible under the page,
   # so layout should not force a default background.
 -   name: android.widget_paints_background