Bug 1624740 - Use io.StringIO instead of io.BytesIO to capture text in building.py r=froydnj
authorRicky Stewart <rstewart@mozilla.com>
Thu, 26 Mar 2020 12:13:25 +0000
changeset 520593 37445084f5f86f46d281d007ed5d26ae76ad6c37
parent 520592 7c9e6706d6b58c5534766917e9baf7bf466e23fc
child 520594 2af0c41aaf248806017dcc4cdf6b0563b8ce4d0f
push id37253
push usernerli@mozilla.com
push dateThu, 26 Mar 2020 21:36:52 +0000
treeherdermozilla-central@c644dd16e2cc [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1624740
milestone76.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1624740 - Use io.StringIO instead of io.BytesIO to capture text in building.py r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D68201
python/mozbuild/mozbuild/controller/building.py
--- a/python/mozbuild/mozbuild/controller/building.py
+++ b/python/mozbuild/mozbuild/controller/building.py
@@ -1395,17 +1395,17 @@ class BuildDriver(MozbuildObject):
     def _clobber_configure(self):
         # This is an optimistic treatment of the CLOBBER file for when we have
         # some trust in the build system: an update to the CLOBBER file is
         # interpreted to mean that configure will fail during an incremental
         # build, which is handled by removing intermediate configure artifacts
         # and subsections of the objdir related to python and testing before
         # proceeding.
         clobberer = Clobberer(self.topsrcdir, self.topobjdir)
-        clobber_output = io.BytesIO()
+        clobber_output = io.StringIO()
         res = clobberer.maybe_do_clobber(os.getcwd(), False,
                                          clobber_output)
         required, performed, message = res
         assert not performed
         if not required:
             return False
 
         def remove_objdir_path(path):