Bug 1068022 - Fix more bad implicit constructors in gfx; r=jrmuizel
authorEhsan Akhgari <ehsan@mozilla.com>
Wed, 17 Sep 2014 17:54:13 -0400
changeset 205914 372251a60bd8f9a11c9a7deacfa221e605b5e4c8
parent 205913 c47bac10dc1879c8b44da056fac791ccf208d7eb
child 205915 0cc9fcdca191f5e078e6201e67b4e84b4e811f69
push id27507
push userryanvm@gmail.com
push dateThu, 18 Sep 2014 02:16:54 +0000
treeherdermozilla-central@488d490da742 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjrmuizel
bugs1068022
milestone35.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1068022 - Fix more bad implicit constructors in gfx; r=jrmuizel
gfx/layers/apz/src/AsyncPanZoomController.cpp
gfx/layers/ipc/ThreadSafeRefcountingWithMainThreadDestruction.h
--- a/gfx/layers/apz/src/AsyncPanZoomController.cpp
+++ b/gfx/layers/apz/src/AsyncPanZoomController.cpp
@@ -405,17 +405,17 @@ GetFrameTime() {
   if (sFrameTime.IsNull()) {
     return TimeStamp::Now();
   }
   return sFrameTime;
 }
 
 class MOZ_STACK_CLASS StateChangeNotificationBlocker {
 public:
-  StateChangeNotificationBlocker(AsyncPanZoomController* aApzc)
+  explicit StateChangeNotificationBlocker(AsyncPanZoomController* aApzc)
     : mApzc(aApzc)
   {
     ReentrantMonitorAutoEnter lock(mApzc->mMonitor);
     mInitialState = mApzc->mState;
     mApzc->mNotificationBlockers++;
   }
 
   ~StateChangeNotificationBlocker()
--- a/gfx/layers/ipc/ThreadSafeRefcountingWithMainThreadDestruction.h
+++ b/gfx/layers/ipc/ThreadSafeRefcountingWithMainThreadDestruction.h
@@ -36,17 +36,17 @@ struct HelperForMainThreadDestruction
     MOZ_ASSERT(NS_IsMainThread());
   }
 };
 
 template<typename T>
 struct DeleteOnMainThreadTask: public nsRunnable
 {
   T* mToDelete;
-  DeleteOnMainThreadTask(T* aToDelete) : mToDelete(aToDelete) {}
+  explicit DeleteOnMainThreadTask(T* aToDelete) : mToDelete(aToDelete) {}
   NS_IMETHOD Run() {
     MOZ_ASSERT(NS_IsMainThread());
     mToDelete->DeleteToBeCalledOnMainThread();
     return NS_OK;
   }
 };
 
 } // namespace layers
@@ -82,9 +82,9 @@ public:                                 
     return count;                                                             \
   }                                                                           \
 protected:                                                                    \
   ::mozilla::ThreadSafeAutoRefCnt mRefCnt;                                    \
 private:                                                                      \
   ::mozilla::layers::HelperForMainThreadDestruction mHelperForMainThreadDestruction; \
 public:
 
-#endif
\ No newline at end of file
+#endif