Bug 1197527 - Don't unnecessarily attempt to create extensions directory in MercurialUpdater; r=gps
authorBirunthan Mohanathas <birunthan@mohanathas.com>
Sat, 22 Aug 2015 13:50:05 -0700
changeset 259084 36786f4a30740917c9e652754a28967bf5d609e1
parent 259083 b4abf0606e3b0ba61e8ba29e174a009f3f464b59
child 259085 2a79899cf4f76ff12b3b2c73151b7f953080c209
push id29268
push userryanvm@gmail.com
push dateTue, 25 Aug 2015 00:37:23 +0000
treeherdermozilla-central@08015770c9d6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1197527
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1197527 - Don't unnecessarily attempt to create extensions directory in MercurialUpdater; r=gps
tools/mercurial/hgsetup/update.py
--- a/tools/mercurial/hgsetup/update.py
+++ b/tools/mercurial/hgsetup/update.py
@@ -18,27 +18,20 @@ FINISHED = '''
 Your Mercurial recommended extensions are now up to date!
 '''.lstrip()
 
 
 class MercurialUpdater(object):
 
     def __init__(self, state_dir):
         self.state_dir = os.path.normpath(state_dir)
-        self.ext_dir = os.path.join(self.state_dir, 'mercurial', 'extensions')
         self.vcs_tools_dir = os.path.join(self.state_dir, 'version-control-tools')
 
     def update_all(self):
         try:
-            os.makedirs(self.ext_dir)
-        except OSError as e:
-            if e.errno != errno.EEXIST:
-                raise
-
-        try:
             hg = which.which('hg')
         except which.WhichError as e:
             print(e)
             print('Try running |mach bootstrap| to ensure your environment is '
                 'up to date.')
             return 1
 
         if os.path.isdir(self.vcs_tools_dir):