Bug 1240260 - Annotate intentional switch fallthroughs in dom/smil/ and dom/svg/. r=dholbert
authorChris Peterson <cpeterson@mozilla.com>
Thu, 14 Jan 2016 01:38:47 -0800
changeset 280367 3667aeb5ab27856095c3be52cc618415971f5527
parent 280366 36447eaea97930cd675b5868acc0982684d80082
child 280368 bbbedf2904265027f7406f2c4935518b7c863765
push id29912
push usercbook@mozilla.com
push dateMon, 18 Jan 2016 13:23:03 +0000
treeherdermozilla-central@a77b73c7723e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1240260
milestone46.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1240260 - Annotate intentional switch fallthroughs in dom/smil/ and dom/svg/. r=dholbert dom/smil/nsSMILParserUtils.cpp:191:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGPathSegListSMILType.cpp:356:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGPathSegListSMILType.cpp:364:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGTransformListParser.cpp:147:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGTransformListParser.cpp:175:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels dom/svg/SVGTransformListParser.cpp:204:5 [-Wimplicit-fallthrough] unannotated fall-through between switch labels
dom/smil/nsSMILParserUtils.cpp
dom/svg/SVGPathSegListSMILType.cpp
dom/svg/SVGTransformListParser.cpp
--- a/dom/smil/nsSMILParserUtils.cpp
+++ b/dom/smil/nsSMILParserUtils.cpp
@@ -182,17 +182,17 @@ ParseClockValue(RangedPtr<const char16_t
   uint32_t minutes, seconds, multiplier;
 
   switch (clockType) {
     case FULL_CLOCK_VALUE:
       if (!SVGContentUtils::ParseInteger(iter, aEnd, hours) ||
           !ParseColon(iter, aEnd)) {
         return false;
       }
-      // intentional fall through
+      MOZ_FALLTHROUGH;
     case PARTIAL_CLOCK_VALUE:
       if (!ParseSecondsOrMinutes(iter, aEnd, minutes) ||
           !ParseColon(iter, aEnd) ||
           !ParseSecondsOrMinutes(iter, aEnd, seconds)) {
         return false;
       }
       if (iter != aEnd &&
           (*iter != '.' ||
--- a/dom/svg/SVGPathSegListSMILType.cpp
+++ b/dom/svg/SVGPathSegListSMILType.cpp
@@ -347,25 +347,25 @@ ConvertPathSegmentData(SVGPathDataAndInf
       aResult[7] = aStart[7];
       AdjustSegmentForRelativeness(adjustmentType, aResult + 6, aState);
       break;
     case PATHSEG_CURVETO_CUBIC_ABS:
     case PATHSEG_CURVETO_CUBIC_REL:
       aResult[5] = aStart[5];
       aResult[6] = aStart[6];
       AdjustSegmentForRelativeness(adjustmentType, aResult + 5, aState);
-      // fall through
+      MOZ_FALLTHROUGH;
     case PATHSEG_CURVETO_QUADRATIC_ABS:
     case PATHSEG_CURVETO_QUADRATIC_REL:
     case PATHSEG_CURVETO_CUBIC_SMOOTH_ABS:
     case PATHSEG_CURVETO_CUBIC_SMOOTH_REL:
       aResult[3] = aStart[3];
       aResult[4] = aStart[4];
       AdjustSegmentForRelativeness(adjustmentType, aResult + 3, aState);
-      // fall through
+      MOZ_FALLTHROUGH;
     case PATHSEG_MOVETO_ABS:
     case PATHSEG_MOVETO_REL:
     case PATHSEG_LINETO_ABS:
     case PATHSEG_LINETO_REL:
     case PATHSEG_CURVETO_QUADRATIC_SMOOTH_ABS:
     case PATHSEG_CURVETO_QUADRATIC_SMOOTH_REL:
       aResult[1] = aStart[1];
       aResult[2] = aStart[2];
--- a/dom/svg/SVGTransformListParser.cpp
+++ b/dom/svg/SVGTransformListParser.cpp
@@ -138,17 +138,17 @@ SVGTransformListParser::ParseTranslate()
 
   if (!ParseArguments(t, ArrayLength(t), &count)) {
     return false;
   }
 
   switch (count) {
     case 1:
       t[1] = 0.f;
-      // fall-through
+      MOZ_FALLTHROUGH;
     case 2:
     {
       nsSVGTransform* transform = mTransforms.AppendElement(fallible);
       if (!transform) {
         return false;
       }
       transform->SetTranslate(t[0], t[1]);
       return true;
@@ -166,17 +166,17 @@ SVGTransformListParser::ParseScale()
 
   if (!ParseArguments(s, ArrayLength(s), &count)) {
     return false;
   }
 
   switch (count) {
     case 1:
       s[1] = s[0];
-      // fall-through
+      MOZ_FALLTHROUGH;
     case 2:
     {
       nsSVGTransform* transform = mTransforms.AppendElement(fallible);
       if (!transform) {
         return false;
       }
       transform->SetScale(s[0], s[1]);
       return true;
@@ -195,17 +195,17 @@ SVGTransformListParser::ParseRotate()
 
   if (!ParseArguments(r, ArrayLength(r), &count)) {
     return false;
   }
 
   switch (count) {
     case 1:
       r[1] = r[2] = 0.f;
-      // fall-through
+      MOZ_FALLTHROUGH;
     case 3:
     {
       nsSVGTransform* transform = mTransforms.AppendElement(fallible);
       if (!transform) {
         return false;
       }
       transform->SetRotate(r[0], r[1], r[2]);
       return true;