Backed out changeset b9c222097ae1 (bug 1522893) for devtools failures at devtools/client/storage/test/browser_storage_delete.js on a CLOSED TREE
authorCoroiu Cristina <ccoroiu@mozilla.com>
Tue, 19 Mar 2019 19:06:34 +0200
changeset 465053 3653c185546ba9b9e720cc135a28f87f09ba1ac7
parent 465052 62309305a091c6b5a843dc78e34a25748cf4dd4d
child 465054 1239a10882e9609b39ff38a1adcb44e92339fc0a
push id35730
push userrmaries@mozilla.com
push dateTue, 19 Mar 2019 21:51:47 +0000
treeherdermozilla-central@4f6d8ed9e948 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1522893
milestone68.0a1
backs outb9c222097ae1e830e0d075677976463df0fd289f
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset b9c222097ae1 (bug 1522893) for devtools failures at devtools/client/storage/test/browser_storage_delete.js on a CLOSED TREE
devtools/client/storage/ui.js
--- a/devtools/client/storage/ui.js
+++ b/devtools/client/storage/ui.js
@@ -1114,20 +1114,16 @@ class StorageUI {
    */
   handleKeypress(event) {
     if (event.keyCode == KeyCodes.DOM_VK_ESCAPE && !this.sidebar.hidden) {
       // Stop Propagation to prevent opening up of split console
       this.hideSidebar();
       this.sidebarToggledOpen = false;
       event.stopPropagation();
       event.preventDefault();
-    } else if (event.keyCode == KeyCodes.DOM_VK_BACK_SPACE && this.table.selectedRow) {
-      this.onRemoveItem();
-      event.stopPropagation();
-      event.preventDefault();
     }
   }
 
   /**
    * Handles filtering the table
    */
   filterItems() {
     const value = this.searchBox.value;
@@ -1299,27 +1295,23 @@ class StorageUI {
   }
 
   /**
    * Handles removing an item from the storage
    */
   onRemoveItem() {
     const [, host, ...path] = this.tree.selectedItem;
     const front = this.getCurrentFront();
-    const uniqueId = this.table.uniqueId;
-    const rowId = this.table.selectedRow[uniqueId];
+    const rowId = this.table.contextMenuRowId;
     const data = this.table.items.get(rowId);
-
     let name = data[this.table.uniqueId];
     if (path.length > 0) {
       name = JSON.stringify([...path, name]);
     }
     front.removeItem(host, name);
-
-    return false;
   }
 
   /**
    * Handles removing all items from the storage
    */
   onRemoveAll() {
     // Cannot use this.currentActor() if the handler is called from the
     // tree context menu: it returns correct value only after the table