Bug 1536589 - Tidy up a few items .eslintignore to make it clearer what needs fixing and what doesn't. r=mossop
authorMark Banner <standard8@mozilla.com>
Mon, 08 Apr 2019 20:06:13 +0000
changeset 468420 3638b253a2e4a243b22612cb47121bd48ccabfb0
parent 468419 a1ec8a73e99bb271e951e0f3e7bc093d02b258e9
child 468421 6e7f3417ee5639add10e58d697ef0f1510dab0ef
push id35837
push userrmaries@mozilla.com
push dateTue, 09 Apr 2019 03:43:40 +0000
treeherdermozilla-central@9eb55c9bf557 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmossop
bugs1536589
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1536589 - Tidy up a few items .eslintignore to make it clearer what needs fixing and what doesn't. r=mossop Depends on D26542 Differential Revision: https://phabricator.services.mozilla.com/D26543
.eslintignore
--- a/.eslintignore
+++ b/.eslintignore
@@ -18,43 +18,44 @@ extensions/cookie/**
 extensions/spellcheck/**
 extensions/universalchardet/**
 image/**
 layout/**
 netwerk/cookie/test/browser/**
 netwerk/test/browser/**
 netwerk/test/mochitests/**
 netwerk/test/unit*/**
-tools/update-packaging/**
-xpfe/**
+startupcache/**
 
 # We currently have no js files in these directories, so we ignore them by
 # default to aid ESLint's performance.
 build/**
 config/**
 db/**
 embedding/**
 gradle/**
 hal/**
 mfbt/**
 mozglue/**
 nsprpub/**
 other-licenses/**
-startupcache/**
+xpfe/**
 
 # These directories only contain crashtests, but we still skip the whole
 # directory to aid performance.
 view/**
 
 # browser/ exclusions
 browser/app/**
 browser/branding/**/firefox-branding.js
 # Gzipped test file.
 browser/base/content/test/general/gZipOfflineChild.html
 browser/base/content/test/urlbar/file_blank_but_not_blank.html
+# Third-party code.
+browser/components/payments/res/vendor/*
 # Test files that are really json not js, and don't need to be linted.
 browser/components/sessionstore/test/unit/data/sessionstore_valid.js
 browser/components/sessionstore/test/unit/data/sessionstore_invalid.js
 # This file is split into two in order to keep it as a valid json file
 # for documentation purposes (policies.json) but to be accessed by the
 # code as a .jsm (schema.jsm)
 browser/components/enterprisepolicies/schemas/schema.jsm
 # generated & special files in cld2
@@ -149,17 +150,17 @@ devtools/client/webconsole/test/mochites
 devtools/client/webconsole/test/mochitest/code_bundle_invalidmap.js
 devtools/server/tests/unit/babel_and_browserify_script_with_source_map.js
 devtools/server/tests/unit/setBreakpoint*
 devtools/server/tests/unit/sourcemapped.js
 
 # devtools specific format test file
 devtools/server/tests/unit/xpcshell_debugging_script.js
 
-# dom/ exclusions
+# dom/ exclusions which should be removed (aka ESLint enabled)
 dom/animation/**
 dom/base/*.*
 dom/base/test/*.*
 dom/base/test/unit/test_serializers_entities*.js
 dom/base/test/unit_ipc/**
 dom/base/test/jsmodules/**
 dom/canvas/**
 dom/encoding/**
@@ -186,17 +187,16 @@ dom/push/**
 dom/quota/**
 dom/security/test/cors/**
 dom/security/test/csp/**
 dom/security/test/general/**
 dom/security/test/mixedcontentblocker/**
 dom/security/test/sri/**
 dom/serviceworkers/**
 dom/smil/**
-
 dom/tests/html/**
 dom/tests/mochitest/**
 dom/u2f/**
 dom/vr/**
 dom/webauthn/**
 dom/webgpu/**
 dom/websocket/**
 dom/workers/**
@@ -286,16 +286,20 @@ remote/test/demo.js
 # security/ exclusions (pref files).
 security/manager/ssl/security-prefs.js
 
 # NSS / taskcluster only.
 security/nss/**
 
 # services/ exclusions
 
+# Third party services
+services/common/kinto-http-client.js
+services/common/kinto-offline-client.js
+
 # Webpack-bundled library
 services/fxaccounts/FxAccountsPairingChannel.js
 
 # Uses `#filter substitution`
 services/sync/modules/constants.js
 services/sync/services-sync.js
 
 # Servo is imported.
@@ -332,38 +336,43 @@ testing/raptor/raptor/playback/scripts/c
 
 testing/web-platform/**
 testing/xpcshell/moz-http2/**
 testing/xpcshell/node-http2/**
 testing/xpcshell/dns-packet/**
 testing/xpcshell/node-ip/**
 
 
-# Third party services
-services/common/kinto-http-client.js
-services/common/kinto-offline-client.js
+# Third party.
+third_party/**
 
 # toolkit/ exclusions
-toolkit/content/widgets/wizard.xml
+
+# Ignore generated code from wasm-bindgen
+toolkit/components/extensions/profiler_get_symbols.js
 
 # Intentionally invalid JS
 toolkit/components/workerloader/tests/moduleF-syntax-error.js
 
-# Tests old non-star function generators
-toolkit/modules/tests/xpcshell/test_task.js
-
 # External code:
-browser/components/payments/res/vendor/*
 toolkit/components/reader/Readability.js
 toolkit/components/reader/JSDOMParser.js
 
 # Uses preprocessing
 toolkit/components/reader/Readerable.jsm
-toolkit/modules/AppConstants.jsm
+
+# Should be going away soon
+toolkit/content/widgets/wizard.xml
+
+# Uses preprocessing
 toolkit/mozapps/update/tests/data/xpcshellConstantsPP.js
-tools/tryselect/selectors/chooser/templates/chooser.html
+toolkit/modules/AppConstants.jsm
+
+# Tests old non-star function generators
+toolkit/modules/tests/xpcshell/test_task.js
 
 # Third party
 toolkit/modules/third_party/**
-third_party/**
+
+tools/tryselect/selectors/chooser/templates/chooser.html
 
-# Ignore generated code from wasm-bindgen
-toolkit/components/extensions/profiler_get_symbols.js
+# Ignore preprocessed *(P)refs.js files in update-packaging.
+tools/update-packaging/**/*refs.js