Bug 1389010, part 8 - Stop abusing mAllBordersSameStyle in nsCSSBorderRenderer::DrawBorders to force drawing as separate parts. r=dholbert
authorJonathan Watt <jwatt@jwatt.org>
Tue, 08 Aug 2017 11:24:56 +0100
changeset 375337 360cd29a8a045e21618cfcae5b21136bbc011ee4
parent 375336 a1b0eecb3ab59f68b9668780a8d264a59226fb90
child 375338 6b4f89f34b11bcb987511cdb6923920d2596f001
push id32355
push userkwierso@gmail.com
push dateThu, 17 Aug 2017 23:17:14 +0000
treeherdermozilla-central@a6a1f5c1d971 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdholbert
bugs1389010
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1389010, part 8 - Stop abusing mAllBordersSameStyle in nsCSSBorderRenderer::DrawBorders to force drawing as separate parts. r=dholbert MozReview-Commit-ID: AiGmfUgB6ql
layout/painting/nsCSSRenderingBorders.cpp
--- a/layout/painting/nsCSSRenderingBorders.cpp
+++ b/layout/painting/nsCSSRenderingBorders.cpp
@@ -3362,19 +3362,18 @@ nsCSSBorderRenderer::DrawBorders()
 
   int dashedSides = 0;
 
   NS_FOR_CSS_SIDES(i) {
     uint8_t style = mBorderStyles[i];
     if (style == NS_STYLE_BORDER_STYLE_DASHED ||
         style == NS_STYLE_BORDER_STYLE_DOTTED)
     {
-      // pretend that all borders aren't the same; we need to draw
-      // things separately for dashed/dotting
-      mAllBordersSameStyle = false;
+      // we need to draw things separately for dashed/dotting
+      forceSeparateCorners = true;
       dashedSides |= (1 << i);
     }
   }
 
   PrintAsFormatString(" mAllBordersSameStyle: %d dashedSides: 0x%02x\n", mAllBordersSameStyle, dashedSides);
 
   if (mAllBordersSameStyle && !forceSeparateCorners) {
     /* Draw everything in one go */