Bug 1560064 - Barrier: Remove JS_BROKEN_GCC_ATTRIBUTE_WARNING guards. r=sfink
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Thu, 20 Jun 2019 19:19:58 +0200
changeset 479338 359226eb7bf50d2c23745c64979e92285ec5c830
parent 479337 a94af4770d783d0a25bfd81b47f5b125a9fb2b2a
child 479339 74b3b3d1544c71eecda9de902a09573f6329cb0d
child 479698 5392c325d0229333a4479fd4a993633403960cc1
push id36178
push useraiakab@mozilla.com
push dateThu, 20 Jun 2019 21:50:59 +0000
treeherdermozilla-central@74b3b3d1544c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfink
bugs1560064
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1560064 - Barrier: Remove JS_BROKEN_GCC_ATTRIBUTE_WARNING guards. r=sfink
js/src/gc/Barrier.cpp
--- a/js/src/gc/Barrier.cpp
+++ b/js/src/gc/Barrier.cpp
@@ -165,36 +165,27 @@ template <typename T>
   if (!zone->maybeGetUniqueId(k, &keyId)) {
     // Key is dead and cannot match lookup which must be live.
     return false;
   }
 
   return keyId == zone->getUniqueIdInfallible(l);
 }
 
-#ifdef JS_BROKEN_GCC_ATTRIBUTE_WARNING
-#  pragma GCC diagnostic push
-#  pragma GCC diagnostic ignored "-Wattributes"
-#endif  // JS_BROKEN_GCC_ATTRIBUTE_WARNING
-
 #if !MOZ_IS_GCC
 template struct JS_PUBLIC_API MovableCellHasher<JSObject*>;
 #endif
 
 template struct JS_PUBLIC_API MovableCellHasher<GlobalObject*>;
 template struct JS_PUBLIC_API MovableCellHasher<SavedFrame*>;
 template struct JS_PUBLIC_API MovableCellHasher<EnvironmentObject*>;
 template struct JS_PUBLIC_API MovableCellHasher<WasmInstanceObject*>;
 template struct JS_PUBLIC_API MovableCellHasher<JSScript*>;
 template struct JS_PUBLIC_API MovableCellHasher<LazyScript*>;
 
-#ifdef JS_BROKEN_GCC_ATTRIBUTE_WARNING
-#  pragma GCC diagnostic pop
-#endif  // JS_BROKEN_GCC_ATTRIBUTE_WARNING
-
 }  // namespace js
 
 JS_PUBLIC_API void JS::HeapObjectWriteBarriers(JSObject** objp, JSObject* prev,
                                                JSObject* next) {
   MOZ_ASSERT(objp);
   js::InternalBarrierMethods<JSObject*>::preBarrier(prev);
   js::InternalBarrierMethods<JSObject*>::postBarrier(objp, prev, next);
 }