Bug 1322650 - Don't use inout param for Surface in ICodec r=jolin
☠☠ backed out by a5e2d088c2ed ☠ ☠
authorJames Willcox <snorp@snorp.net>
Fri, 03 Mar 2017 15:19:04 -0600
changeset 357994 3522917d8f1067fea995f38cd6910b76ef263d64
parent 357993 2c2c1e33ecccda814f4bc2504bbe2e833db7eabc
child 357995 bd53533c108e4c38eda77d4cba904e2f12042772
push id31808
push usercbook@mozilla.com
push dateFri, 12 May 2017 12:37:49 +0000
treeherdermozilla-central@030c0a7c8781 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjolin
bugs1322650
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1322650 - Don't use inout param for Surface in ICodec r=jolin It's unnecessary, and the serialization goes wrong with GeckoSurface on the return trip. MozReview-Commit-ID: 9DUMoLQFhlv
mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
--- a/mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
+++ b/mobile/android/geckoview/src/main/aidl/org/mozilla/gecko/media/ICodec.aidl
@@ -8,17 +8,17 @@ package org.mozilla.gecko.media;
 import android.os.Bundle;
 import android.view.Surface;
 import org.mozilla.gecko.media.FormatParam;
 import org.mozilla.gecko.media.ICodecCallbacks;
 import org.mozilla.gecko.media.Sample;
 
 interface ICodec {
     void setCallbacks(in ICodecCallbacks callbacks);
-    boolean configure(in FormatParam format, inout Surface surface, int flags, in String drmStubId);
+    boolean configure(in FormatParam format, in Surface surface, int flags, in String drmStubId);
     boolean isAdaptivePlaybackSupported();
     void start();
     void stop();
     void flush();
     void release();
 
     Sample dequeueInput(int size);
     oneway void queueInput(in Sample sample);