Bug 1611951 - Basic documentation of fields of ComputedGridTrackInfo r=emilio
authorEmily McDonough <emcdonough@mozilla.com>
Tue, 28 Jan 2020 16:58:06 +0000
changeset 512025 34f5227046f328b65f912fe413f4dee39f2aab97
parent 512024 59c7ac9564d8bfd397173ab79abdee5f26aa64d7
child 512026 86b7021079e538c062e2be8550f1be90a1eca2a6
child 512027 228931ff1d49b0c474afe1b778218c7cbbb4254e
push id37064
push usershindli@mozilla.com
push dateTue, 28 Jan 2020 21:40:36 +0000
treeherdermozilla-central@34f5227046f3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
bugs1611951
milestone74.0a1
first release with
nightly linux32
34f5227046f3 / 74.0a1 / 20200128214036 / files
nightly linux64
34f5227046f3 / 74.0a1 / 20200128214036 / files
nightly mac
34f5227046f3 / 74.0a1 / 20200128214036 / files
nightly win32
34f5227046f3 / 74.0a1 / 20200128214036 / files
nightly win64
34f5227046f3 / 74.0a1 / 20200128214036 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1611951 - Basic documentation of fields of ComputedGridTrackInfo r=emilio Differential Revision: https://phabricator.services.mozilla.com/D61180
layout/generic/nsGridContainerFrame.h
--- a/layout/generic/nsGridContainerFrame.h
+++ b/layout/generic/nsGridContainerFrame.h
@@ -59,17 +59,23 @@ struct ComputedGridTrackInfo {
         mIsSubgrid(aIsSubgrid) {}
   uint32_t mNumLeadingImplicitTracks;
   uint32_t mNumExplicitTracks;
   uint32_t mStartFragmentTrack;
   uint32_t mEndFragmentTrack;
   nsTArray<nscoord> mPositions;
   nsTArray<nscoord> mSizes;
   nsTArray<uint32_t> mStates;
+  // Indicates if a track has been collapsed. This will be populated for each
+  // track in the repeat(auto-fit) and repeat(auto-fill), even if there are no
+  // collapsed tracks.
   nsTArray<bool> mRemovedRepeatTracks;
+  // Contains lists of all line name lists, including the name lists inside
+  // repeats. When a repeat(auto) track exists, the internal track names will
+  // appear once each in this array.
   nsTArray<nsTArray<StyleCustomIdent>> mResolvedLineNames;
   uint32_t mRepeatFirstTrack;
   bool mIsSubgrid;
 };
 
 struct ComputedGridLineInfo {
   explicit ComputedGridLineInfo(
       nsTArray<nsTArray<RefPtr<nsAtom>>>&& aNames,