mozilla-central: changeset 356467:34280baeaabe27be2c7d587b6e1875d260bdbcdf

☠☠ backed out by 8f8cb62a8749 ☠ ☠
author	Cameron McCormack <cam@mcc.id.au>
	Sun, 30 Apr 2017 14:48:17 +0800
changeset 356467	34280baeaabe27be2c7d587b6e1875d260bdbcdf
parent 356466	31a0881cfb4714a43c725d114775f1b9061d81f4
child 356468	c60b4c9cbd83e774eca3014e1e0d78f67b055b62
push id	31767
push user	cbook@mozilla.com
push date	Fri, 05 May 2017 13:15:58 +0000
treeherder	mozilla-central@8872ad4d52b6 [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	bholley
bugs	1356103
milestone	55.0a1
first release with	nightly linux32 37a5b7f6f101 / 55.0a1 / 20170507100239 / files nightly linux64 37a5b7f6f101 / 55.0a1 / 20170507100239 / files nightly mac 37a5b7f6f101 / 55.0a1 / 20170507030205 / files nightly win32 37a5b7f6f101 / 55.0a1 / 20170507030205 / files nightly win64 37a5b7f6f101 / 55.0a1 / 20170507030205 / files
last release without	nightly linux32 33b92d9c4056 / 55.0a1 / 20170504100326 / files nightly linux64 33b92d9c4056 / 55.0a1 / 20170504100357 / files nightly mac 33b92d9c4056 / 55.0a1 / 20170504030320 / files nightly win32 33b92d9c4056 / 55.0a1 / 20170504030320 / files nightly win64 33b92d9c4056 / 55.0a1 / 20170504030320 / files

Bug 1356103 - Part 6: Make gfxUserFontSet refcounting thread-safe. r=bholley As with a few other gfx* font-related classes, during font metrics calculations we end up taking strong references to gfxUserFontSet, and it would be difficult to restructure the code to not do this. MozReview-Commit-ID: L1GbZnf4825

gfx/thebes/gfxUserFontSet.h

file | annotate | diff | comparison | revisions

--- a/gfx/thebes/gfxUserFontSet.h
+++ b/gfx/thebes/gfxUserFontSet.h
@@ -170,17 +170,17 @@ class gfxUserFontEntry;
 class gfxOTSContext;
 
 class gfxUserFontSet {
     friend class gfxUserFontEntry;
     friend class gfxOTSContext;
 
 public:
 
-    NS_INLINE_DECL_REFCOUNTING(gfxUserFontSet)
+    NS_INLINE_DECL_THREADSAFE_REFCOUNTING(gfxUserFontSet)
 
     gfxUserFontSet();
 
     enum {
         // no flags ==> no hint set
         // unknown ==> unknown format hint set
         FLAG_FORMAT_UNKNOWN        = 1,
         FLAG_FORMAT_OPENTYPE       = 1 << 1,