Bug 1702525 - Urlbar divider is thicker when search mode is open without suggestions. r=harry,desktop-theme-reviewers
authorMarco Bonardo <mbonardo@mozilla.com>
Wed, 07 Apr 2021 15:21:19 +0000
changeset 574833 33f51bca9422ebe3894f969e6e1ba4c22521bef8
parent 574832 be2240af9b8da87b266bca9bf34063bd96d60403
child 574834 f54f1e645d983f58ba20a4eb533adff24b83b323
push id38355
push userabutkovits@mozilla.com
push dateWed, 07 Apr 2021 21:25:27 +0000
treeherdermozilla-central@b740f950e497 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersharry, desktop-theme-reviewers
bugs1702525
milestone89.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1702525 - Urlbar divider is thicker when search mode is open without suggestions. r=harry,desktop-theme-reviewers Differential Revision: https://phabricator.services.mozilla.com/D111092
browser/themes/shared/urlbar-searchbar.inc.css
browser/themes/shared/urlbarView.inc.css
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -1029,20 +1029,16 @@ moz-input-box > menupopup .context-menu-
   margin-inline: -4px -7px;
   margin-top: -13px;
 }
 
 #urlbar .searchbar-separator {
   display: none;
 }
 
-#urlbar .search-one-offs {
-  border-top: 1px solid var(--panel-separator-color);
-}
-
 moz-input-box > menupopup .context-menu-add-engine > .menu-iconic-left::after {
   /* These differ from the urlbar and searchbar because the context menu
      may not have enough space */
   margin-inline: -7px -4px;
   margin-top: -8px;
 }
 
 /* Fade a little the icon so that the + badge is more evident and the button
--- a/browser/themes/shared/urlbarView.inc.css
+++ b/browser/themes/shared/urlbarView.inc.css
@@ -709,27 +709,27 @@
 
 #urlbar .search-one-offs:not([hidden]) {
   display: flex;
   align-items: start;
   padding-block: 16px;
   flex-wrap: wrap;
 }
 
+.urlbarView:not([noresults]) > .search-one-offs:not([hidden]) {
+  border-top: 1px solid var(--panel-separator-color);
+}
+
 @media (-moz-proton-urlbar) {
 #urlbar .search-one-offs:not([hidden]) {
   padding-block: 10px;
   border-top-color: var(--urlbar-separator-color);
 }
 } /*** END proton ***/
 
-.urlbarView[noresults] > .search-one-offs {
-  border-top: none;
-}
-
 #urlbar .search-panel-one-offs-container {
   /* Make sure horizontally we can fit four buttons, empty space, settings. */
   min-width: calc(4 * /* one-off with end margin */ 40px + /* settings with start margin */ 56px);
 }
 
 #urlbar .search-panel-header {
   padding: 0;
   min-height: 32px;