Bug 1376109 - Consolidate default sidebarheader styling and don't remove its background for lightweight themes. r=nhnt11
authorDão Gottwald <dao@mozilla.com>
Sat, 24 Jun 2017 17:04:53 +0200
changeset 366472 33e589452ed33f80861c6ed2cd40a5360f817049
parent 366471 d03127f02471aab8a06b9a9b740022b315fef649
child 366473 8e6b53822f7cff83403d0225be8e305440f952fe
push id32104
push usercbook@mozilla.com
push dateThu, 29 Jun 2017 13:46:04 +0000
treeherdermozilla-central@d2aff6fc075d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnhnt11
bugs1376109
milestone56.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1376109 - Consolidate default sidebarheader styling and don't remove its background for lightweight themes. r=nhnt11 MozReview-Commit-ID: CWisvnVYLJc
browser/themes/shared/sidebar.inc.css
toolkit/themes/linux/global/global.css
toolkit/themes/osx/global/global.css
toolkit/themes/windows/global/global.css
--- a/browser/themes/shared/sidebar.inc.css
+++ b/browser/themes/shared/sidebar.inc.css
@@ -4,18 +4,16 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 %endif
 
 .sidebar-header,
 #sidebar-header {
   font-size: 1.333em;
   font-weight: lighter;
   padding: 8px;
-  color: -moz-dialogText;
-  text-shadow: none;
 }
 
 .sidebar-splitter {
   -moz-appearance: none;
   border: 0 solid;
   border-inline-end-width: 1px;
   min-width: 1px;
   width: 3px;
--- a/toolkit/themes/linux/global/global.css
+++ b/toolkit/themes/linux/global/global.css
@@ -122,16 +122,18 @@ statusbarpanel {
   padding: 0 1px;
 }
 
 /* XXXBlake yeah, shoot me -- these don't belong here.  I'll move them later. */
 
 sidebarheader {
   min-height: 25px;
   background-color: -moz-Dialog;
+  color: -moz-dialogText;
+  text-shadow: none;
 }
 
 sidebarheader > label {
   padding-inline-start: 4px;
 }
 
 .toolbar-focustarget {
   -moz-user-focus: ignore !important;
@@ -144,20 +146,16 @@ toolbar[mode="text"] .toolbarbutton-text
 
 /* ::::: miscellaneous formatting ::::: */
 
 :root:-moz-lwtheme,
 statusbarpanel:-moz-lwtheme {
   -moz-appearance: none;
 }
 
-sidebarheader:-moz-lwtheme {
-  background: none;
-}
-
 :root:-moz-lwtheme-darktext {
   text-shadow: 0 -0.5px 1.5px white;
 }
 
 :root:-moz-lwtheme-brighttext {
   text-shadow: 1px 1px 1.5px black;
 }
 
--- a/toolkit/themes/osx/global/global.css
+++ b/toolkit/themes/osx/global/global.css
@@ -119,16 +119,22 @@ statusbarpanel {
 }
 
 .statusbarpanel-iconic {
   padding: 0px;
 }
 
 /* ::::: miscellaneous formatting ::::: */
 
+sidebarheader {
+  background-color: -moz-Dialog;
+  color: -moz-dialogText;
+  text-shadow: none;
+}
+
 :root:-moz-lwtheme {
   -moz-appearance: none;
 }
 
 :root:-moz-lwtheme-darktext {
   text-shadow: 0 -0.5px 1.5px white;
 }
 
--- a/toolkit/themes/windows/global/global.css
+++ b/toolkit/themes/windows/global/global.css
@@ -131,16 +131,18 @@ statusbarpanel:not(.statusbar-resizerpan
   padding: 0 1px;
 }
 
 /* XXXBlake yeah, shoot me -- these don't belong here.  I'll move them later. */
 
 sidebarheader {
   min-height: 25px;
   background-color: -moz-Dialog;
+  color: -moz-dialogText;
+  text-shadow: none;
   -moz-appearance: toolbox;
   border-bottom: 1px solid ThreeDShadow;
   border-top: 1px solid ThreeDHighlight;
 }
 
 sidebarheader > label {
   padding-inline-start: 4px;
 }
@@ -163,18 +165,17 @@ toolbar[mode="text"] .toolbarbutton-text
 :root:-moz-lwtheme-darktext {
   text-shadow: 0 -0.5px 1.5px white;
 }
 
 :root:-moz-lwtheme-brighttext {
   text-shadow: 1px 1px 1.5px black;
 }
 
-statusbar:-moz-lwtheme,
-sidebarheader:-moz-lwtheme {
+statusbar:-moz-lwtheme {
   -moz-appearance: none;
   background: none;
   border-style: none;
 }
 
 .inset {
   border: 1px solid ThreeDShadow;
   border-right-color: ThreeDHighlight;