Bug 1750239 - Set beConservative by default in GeckoWebExecutor. r=owlish,calu
authorAgi Sferro <agi@sferro.dev>
Fri, 14 Jan 2022 21:07:16 +0000
changeset 604603 33580fdf015f42a1dcae0ba2b223569ed684b5a7
parent 604602 b439d416831424beda57c4169a8ecb5cf39a0d29
child 604604 6e94875e1ef32abb08f9a66bd43dc06b0f8f979d
push id39152
push userabutkovits@mozilla.com
push dateSat, 15 Jan 2022 09:45:36 +0000
treeherdermozilla-central@60998033086a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersowlish, calu
bugs1750239
milestone98.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1750239 - Set beConservative by default in GeckoWebExecutor. r=owlish,calu BeConservative ensures that Gecko will not use bleeding-edge features like HTTP3 to avoid breaking core browser functionality. Differential Revision: https://phabricator.services.mozilla.com/D136024
widget/android/WebExecutorSupport.cpp
--- a/widget/android/WebExecutorSupport.cpp
+++ b/widget/android/WebExecutorSupport.cpp
@@ -345,16 +345,20 @@ static nsresult SetupHttpChannel(nsIHttp
 
   int32_t cacheMode;
   rv = ConvertCacheMode(req->CacheMode(), cacheMode);
   NS_ENSURE_SUCCESS(rv, rv);
 
   rv = internalChannel->SetFetchCacheMode(cacheMode);
   NS_ENSURE_SUCCESS(rv, rv);
 
+  // TODO: Bug 1750231 - make this configurable
+  rv = internalChannel->SetBeConservative(true);
+  NS_ENSURE_SUCCESS(rv, rv);
+
   // We don't have any UI
   rv = internalChannel->SetBlockAuthPrompt(true);
   NS_ENSURE_SUCCESS(rv, rv);
 
   return NS_OK;
 }
 
 nsresult WebExecutorSupport::CreateStreamLoader(