Backed out changeset ccd3a06efe81 (bug 1638138) for perma failures on browser_test_procinfo.js. CLOSED TREE
authorRazvan Maries <rmaries@mozilla.com>
Fri, 15 May 2020 17:48:53 +0300
changeset 530283 332e06a545d2667fd940d5bf0150bb372146559e
parent 530282 54b7351d87ebdf372ad0e721cb83fe7f807927f5
child 530284 759d1658e2b35be2e25dbd375782ef66b4176486
push id37420
push usernerli@mozilla.com
push dateFri, 15 May 2020 21:52:36 +0000
treeherdermozilla-central@f340bbb582d1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1638138
milestone78.0a1
backs outccd3a06efe81123e9ff32a697bc3c0f54e26a734
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset ccd3a06efe81 (bug 1638138) for perma failures on browser_test_procinfo.js. CLOSED TREE
dom/base/ChromeUtils.cpp
widget/tests/browser/browser_test_procinfo.js
--- a/dom/base/ChromeUtils.cpp
+++ b/dom/base/ChromeUtils.cpp
@@ -941,17 +941,16 @@ already_AddRefed<Promise> ChromeUtils::R
                         threads.AppendElement(fallible);
                     if (NS_WARN_IF(!thread)) {
                       domPromise->MaybeReject(NS_ERROR_OUT_OF_MEMORY);
                       return;
                     }
                     thread->mCpuUser = entry.cpuUser;
                     thread->mCpuKernel = entry.cpuKernel;
                     thread->mTid = entry.tid;
-                    thread->mName.Assign(entry.name);
                   }
                   procInfo.mThreads = std::move(threads);
 
                   mozilla::dom::Sequence<mozilla::dom::ChildProcInfoDictionary>
                       children;
                   for (const ProcInfo& info : aChildrenInfo) {
                     ChildProcInfoDictionary* childProcInfo =
                         children.AppendElement(fallible);
--- a/widget/tests/browser/browser_test_procinfo.js
+++ b/widget/tests/browser/browser_test_procinfo.js
@@ -26,21 +26,16 @@ add_task(async function test_proc_info()
           "browser",
           "Parent proc type should be browser"
         );
 
         for (var x = 0; x < parentProc.threads.length; x++) {
           cpuThreads += parentProc.threads[x].cpuUser;
         }
 
-        Assert.ok(
-          parentProc.threads.some(thread => thread.name),
-          "At least one of the threads of the parent process is named"
-        );
-
         for (var i = 0; i < parentProc.children.length; i++) {
           let childProc = parentProc.children[i];
           Assert.notEqual(
             childProc.type,
             "browser",
             "Child proc type should not be browser"
           );
           Assert.notEqual(