Bug 1334027 - Add unloaded modules and process/thread data to minidumps. r=ted
authorTing-Yu Chou <janus926@gmail.com>
Thu, 02 Feb 2017 09:33:01 +0800
changeset 341347 3305ef5e8faa24988d6835f34c75e9e9eb29821d
parent 341346 2f0968db9234a6e63f6fef6a82a9133b8f99aae5
child 341348 eabcf85ca6408755829890abaf0a57d965686de9
push id31331
push userkwierso@gmail.com
push dateWed, 08 Feb 2017 23:48:12 +0000
treeherdermozilla-central@438b18daff7a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs1334027
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1334027 - Add unloaded modules and process/thread data to minidumps. r=ted MozReview-Commit-ID: LpiE5f9dYqM
toolkit/crashreporter/nsExceptionHandler.cpp
--- a/toolkit/crashreporter/nsExceptionHandler.cpp
+++ b/toolkit/crashreporter/nsExceptionHandler.cpp
@@ -1502,16 +1502,25 @@ MINIDUMP_TYPE GetMinidumpType()
       VerQueryValue(&buffer[0], L"\\", (void**)&file_info, &len);
       WORD major = HIWORD(file_info->dwFileVersionMS),
         minor = LOWORD(file_info->dwFileVersionMS),
         revision = HIWORD(file_info->dwFileVersionLS);
       if (major > 6 || (major == 6 && minor > 1) ||
           (major == 6 && minor == 1 && revision >= 7600)) {
         minidump_type = MiniDumpWithFullMemoryInfo;
       }
+#ifdef NIGHTLY_BUILD
+      // TODO: Remove the NIGHTLY_BUILD wrapping if the increased size is
+      // accetable.
+      if (major > 5 || (major == 5 && minor > 1)) {
+        minidump_type = static_cast<MINIDUMP_TYPE>(minidump_type |
+            MiniDumpWithUnloadedModules |
+            MiniDumpWithProcessThreadData);
+      }
+#endif
     }
   }
 
   const char* e = PR_GetEnv("MOZ_CRASHREPORTER_FULLDUMP");
   if (e && *e) {
     minidump_type = MiniDumpWithFullMemory;
   }