Bug 1434305 - Part 12: Remove JS::ExposeScriptToActiveJS call on scripts returned by IterateScripts. r=jimb,f=jonco
authorTooru Fujisawa <arai_a@mac.com>
Thu, 26 Jul 2018 12:36:18 +0900
changeset 428530 32dd0504e5972bef289c5b25cbc19a6351a9e59b
parent 428529 103ff157601000c175c987abdf43d42a83650c41
child 428531 960a1f20a4117ed597bd89238c0cc53d4be4b5c3
push id34337
push userncsoregi@mozilla.com
push dateThu, 26 Jul 2018 21:58:45 +0000
treeherdermozilla-central@8f2f847b2f9d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjimb
bugs1434305
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1434305 - Part 12: Remove JS::ExposeScriptToActiveJS call on scripts returned by IterateScripts. r=jimb,f=jonco This is no more necessary because we have read barrier in IterateScripts that does the same thing.
js/src/vm/Debugger.cpp
--- a/js/src/vm/Debugger.cpp
+++ b/js/src/vm/Debugger.cpp
@@ -4408,20 +4408,16 @@ class MOZ_STACK_CLASS Debugger::ScriptQu
         IterateScripts(cx, singletonRealm, this, considerScript);
         if (!delazified)
             IterateLazyScripts(cx, singletonRealm, this, considerLazyScript);
         if (oom) {
             ReportOutOfMemory(cx);
             return false;
         }
 
-        // We cannot touch the gray bits while isHeapBusy, so do this now.
-        for (JSScript** i = scriptVector.begin(); i != scriptVector.end(); ++i)
-            JS::ExposeScriptToActiveJS(*i);
-
         // For most queries, we just accumulate results in 'scriptVector' and
         // 'lazyScriptVector' as we find them. But if this is an 'innermost'
         // query, then we've accumulated the results in the 'innermostForRealm'
         // map. In that case, we now need to walk that map and
         // populate 'scriptVector'.
         if (innermost) {
             for (RealmToScriptMap::Range r = innermostForRealm.all();
                  !r.empty();